fix(image): 修复内联样式不生效 #3254
Open
fix(image): 修复内联样式不生效 #3254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Walkthrough本次变更调整了 Changes
Possibly related PRs
Suggested reviewers
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
github-actions
bot
added
the
action:review
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat_v3.x #3254 +/- ##
=============================================
+ Coverage 87.59% 87.75% +0.16%
=============================================
Files 290 290
Lines 19102 19111 +9
Branches 2930 2938 +8
=============================================
+ Hits 16732 16771 +39
+ Misses 2365 2335 -30
Partials 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
src/packages/image/image.taro.tsx (3)
2-2: 使用import type优化类型导入
当前直接从react导入了CSSProperties，会在运行时保留无用的导入。建议改为：-import React, { - CSSProperties, +import React, { + FunctionComponent, + useCallback, + useState, -} from 'react' +} from 'react' +import type { CSSProperties } from 'react'这样能让编译器在产物中移除类型导入，减少包体积。
61-71: 明确style与内置尺寸样式的覆盖顺序
这里将用户传入的style放在最前面，后续的 height/width/radius 配置会覆盖用户的同名属性；反之，用户若要完全接管尺寸则需在style中手动重写。
建议要么将...(style)放到最后以保证用户优先级，要么在文档中强调属性覆盖规则。
73-77: 统一imgStyle的类型并剥离多余合并
imgStyle当前类型为any且又重复合并了style，会导致容器和图片元素同时应用同一份样式，引发潜在冲突。
- 建议改为
CSSProperties类型：const imgStyle: CSSProperties = { width: pxCheck(width), height: pxCheck(height), }- 如确实需单独自定义图片样式，可新增
imageStyle属性；否则移除对style的二次合并。
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/packages/image/image.taro.tsx(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: build
- GitHub Check: test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个变动的性质是？
🔗 相关 Issue
💡 需求背景和解决方案
☑️ 请求合并前的自查清单
Summary by CodeRabbit