-
Notifications
You must be signed in to change notification settings - Fork 273
fix(switch): 移除重复的onchange回调 #3259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feat_v3.x
Are you sure you want to change the base?
Conversation
Walkthrough本次变更移除了在 Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant SwitchComponent
participant onChangeHandler
User->>SwitchComponent: 点击 Switch
SwitchComponent->>SwitchComponent: 设置 loading 状态
alt 异步调用 onChange
SwitchComponent->>onChangeHandler: await onChange(!value)
onChangeHandler-->>SwitchComponent: 返回(成功或失败)
SwitchComponent->>SwitchComponent: 更新内部值
end
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (5)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat_v3.x #3259 +/- ##
==========================================
Coverage 87.75% 87.75%
==========================================
Files 290 290
Lines 19111 19111
Branches 2937 2938 +1
==========================================
+ Hits 16770 16771 +1
+ Misses 2336 2335 -1
Partials 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…nto feat_v3.x
🤔 这个变动的性质是?
🔗 相关 Issue
💡 需求背景和解决方案
☑️ 请求合并前的自查清单
Summary by CodeRabbit
onChange
的问题,现在只会异步调用一次onChange
。