-
-
Notifications
You must be signed in to change notification settings - Fork 474
feat: new "enable-tools" option #4784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
mise.toml
Outdated
@@ -21,6 +21,7 @@ cosign = "latest" | |||
pre-commit = "latest" | |||
#"python" = { version = "latest", virtualenv = "{{env.HOME}}/.cache/venv" } | |||
"ripgrep" = "latest" | |||
rust = "latest" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
take this out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the intended way to get the correct version of rust?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
took it out for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should just use the latest stable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1.86.0 is stable as of yesterday 😄
will need at least 1 e2e test |
added running locally didn't work
|
you need to install fd, which we could probably add to mise.toml |
I also get
|
even though it's not working locally - the e2e test seems to be working |
@jdx can you take a look? |
@jdx can you help me fix the coverage report?
|
This is what I get with latest main now: (npm is installed locally)
|
Fixes #4777