Skip to content

fix: fix deadlocks caused by uv_venv_auto #4900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
May 3, 2025
Merged

fix: fix deadlocks caused by uv_venv_auto #4900

merged 13 commits into from
May 3, 2025

Conversation

risu729
Copy link
Contributor

@risu729 risu729 commented Apr 22, 2025 •
edited
Loading

Fixes #4600, but still in WIP.

@risu729
Copy link
Contributor Author

risu729 commented Apr 23, 2025 •
edited
Loading

Note:

The root cause of this issue lies in uv_venv_auto attempting to resolve the path to uv, which introduces a cyclic dependency:

toolset → ($npm/go dep env) → config → (uv path) → toolset

This cycle leads to a deadlock in LazyLock or OnceCell due to reentrant initialisation, where an item tries to access itself during its own initialisation.

Ideally, the correct fix would involve resolving the reentrancy issue directly.
However, since that seems complex, I'm trying to workaround by bypassing LazyLock or OnceCell during their initialization phase.
It means returning None or default values instead of trying to init, thus avoiding the deadlock.

@risu729 risu729 marked this pull request as ready for review April 30, 2025 07:43
@risu729
Copy link
Contributor Author

risu729 commented Apr 30, 2025 •
edited
Loading

@jdx I apologise for taking so long to fix my PR.
I confirmed this fixes the deadlock for npm or go backends with uv_venv_auto.

The test seems to fail because of cargo-insta installation.

@jdx jdx merged commit 622a0db into jdx:main May 3, 2025
18 checks passed
@risu729 risu729 deleted the fix-uv-deadlock branch May 3, 2025 16:06
@mise-en-dev mise-en-dev mentioned this pull request May 3, 2025
Merged
jdx pushed a commit that referenced this pull request May 3, 2025
@mise-en-dev
chore: release 2025.5.0 (#4966)
9b4d5e7 
### 🚀 Features

- **(registry)** add luau by [@rhanneken](https://github.com/rhanneken)
in [#4993](#4993)
- **(registry)** add numbat by [@risu729](https://github.com/risu729) in
[#4980](#4980)
- add check flag for the fmt command by
[@roele](https://github.com/roele) in
[#4972](#4972)
- use aqua for btop by [@jdx](https://github.com/jdx) in
[#4979](#4979)

### 🐛 Bug Fixes

- **(java)** filter out JetBrains releases with features by
[@roele](https://github.com/roele) in
[#4970](#4970)
- fix deadlocks caused by uv_venv_auto by
[@risu729](https://github.com/risu729) in
[#4900](#4900)

### 📚 Documentation

- Put dot in dotfile example by
[@ryanbrainard](https://github.com/ryanbrainard) in
[#4965](#4965)

### Chore

- only use mold when available by [@jdx](https://github.com/jdx) in
[#4978](#4978)
- enable clearing screen for confirm and dialog by
[@roele](https://github.com/roele) in
[#4990](#4990)

### New Contributors

- @rhanneken made their first contribution in
[#4993](#4993)
- @ryanbrainard made their first contribution in
[#4965](#4965)
@mise-en-dev mise-en-dev mentioned this pull request May 3, 2025
Merged
@BrewTestBot BrewTestBot mentioned this pull request May 3, 2025
Merged
@jdx jdx mentioned this pull request May 21, 2025
Closed
@risu729 risu729 mentioned this pull request Jul 14, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

npm backend hangs when used with python.uv_venv_auto = true
2 participants
@risu729 @jdx