Skip to content

fix: duplicate entries when running mise settings add idiomatic_version_file_enable_tools #4925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

fix: duplicate entries when running mise settings add idiomatic_version_file_enable_tools #4925

wants to merge 22 commits into from

Conversation

hitblast
Copy link
Contributor

fixes: #4919

@hitblast
Copy link
Contributor Author

hitblast commented Apr 24, 2025 •
edited
Loading

Sorry for the clutter, I was wondering what had happened with my rust-analyzer.

jdx
jdx reviewed Apr 25, 2025
View reviewed changes
@hitblast
Copy link
Contributor Author

Since I'm not really sure how to implement the Set type directly into the code, I've tried an alternate approach to first cross-reference DocumentMut and only dedupe values if the setting in question is an array.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdx jdx jdx left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mise settings add idiomatic_version_file_enable_tools stores duplicates in config
2 participants
@hitblast @jdx