Skip to content

Conversation

@iamkroot
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings December 17, 2025 07:32
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new configuration setting task_show_cmd_no_trunc that allows users to disable truncation of command lines in task execution output. When enabled, the full command line will be displayed regardless of terminal width.

  • Introduces task_show_cmd_no_trunc boolean setting configurable via MISE_TASK_SHOW_CMD_NO_TRUNC environment variable
  • Modifies the trunc() function to check this setting and skip truncation when enabled
  • Optimizes settings access by reusing the same Settings::get() call

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/task/task_output.rs Updates trunc() function to respect the new task_show_cmd_no_trunc setting and refactors to use a single settings instance
settings.toml Adds configuration definition for the new task_show_cmd_no_trunc boolean setting

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@iamkroot
Copy link
Contributor Author

Open to suggestions for better name for the setting.

Can add another setting to only print out first $n$ lines or something. Don't think it's too useful, so skipped.

@jdx
Copy link
Owner

jdx commented Dec 17, 2025

definitely needs a different name

@jdx jdx marked this pull request as draft December 17, 2025 21:52
@iamkroot iamkroot changed the title feat(tasks): Add task_show_cmd_no_trunc setting feat(tasks): Add task_show_full_cmd setting Dec 22, 2025
@iamkroot
Copy link
Contributor Author

Renamed

@iamkroot iamkroot marked this pull request as ready for review December 22, 2025 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants