Diff view review and refactoring#169
Merged
Merged
Conversation
This commit implements the user story from issue #9, allowing Jeddict icons to be displayed before menu items in NetBeans, enhancing visibility and usability. As part of this feature, significant refactoring was undertaken to improve code quality and maintainability: - Introduced `BaseGitAction` to centralize Git project-related action logic. - Introduced `BaseContextAction` for common context-aware action functionalities. - Introduced `BaseProjectContextAction` for project-specific context actions. - Refactored `GenerateCommitMessageAction` and `ReviewAction` to leverage these new base classes. - Added comprehensive Javadoc to all classes within the `io.github.jeddict.ai.actions` package for improved code documentation.
- refactored for better review - added diffWithOriginal to compare any text (i.e. as returned by the AI) with the original source file
…ementation of the StreamSource which uses a FileObject to read the content.
which is an internal class and therefore a brittle dependency. It also gives the basis to build specific functionality for Jeddict or cleaning up the UI removed unused functionalities.
…nu items. This class provides common functionality for setting the action's name, icon, and enabled state.
feat: Implement #9: Show Jeddict icon in NetBeans menus
# Conflicts: # .gitignore # src/main/java/io/github/jeddict/ai/actions/BaseContextAction.java
Diff view review and refactoring
Member
|
Hi, thanks for the improvements. |
jGauravGupta
approved these changes
Sep 2, 2025
jGauravGupta
reviewed
Sep 2, 2025
jGauravGupta
reviewed
Sep 2, 2025
Member
|
Only minor typos in comment, All LGTM. |
Collaborator
Author
Fixed, thanks for spotting it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to refactor for better reuse the panel used to display and deal with diffs.
Note that because #166 was not merged yet, this PR includes those changes too. It's not ideal, but I need to move on my branch. @jGauravGupta, it would be great if you could provide some feedback or more interaction so that we can coordinate better and the contribution process would be more effective.