Fix HumanInTheMiddleWrapper.getDummyArgsFor passing null for Project constructor arg#302
Merged
Merged
Conversation
…constructor arg Co-authored-by: jGauravGupta <15934072+jGauravGupta@users.noreply.github.com>
stefanofornari
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In INTERACTIVE mode,
JeddictBrainwraps every tool withHumanInTheMiddleWrapperto apply human-in-the-middle approval.ProjectToolsand all its subclasses take aProjectas their constructor parameter rather than a plainStringbasedir.getDummyArgsFor()passednullfor any non-primitive, non-String parameter, causingProjectTools(null)→basedirOf(null)→IllegalArgumentException: project cannot be null.Changes
HumanInTheMiddleWrappergetDummyArgsFor(Constructor, Object originalTool)— now accepts the original tool and, for non-primitive/non-String parameters, uses reflection to walk the tool's class hierarchy looking for a field whose type satisfies the required parameter type. The field's actual value is used instead ofnull. Falls back tonullif no matching field is found.getFieldValueByType(Class, Object)helper — traversesgetDeclaredFields+getSuperclass, catches bothIllegalAccessExceptionandSecurityException.