Fix for issue #308 The "chat with AI" is not reading the given file and fires an exception#312
Closed
stefanofornari wants to merge 1 commit into
Closed
Conversation
… file and fires an exception
jGauravGupta
requested changes
Apr 6, 2026
Member
jGauravGupta
left a comment
There was a problem hiding this comment.
Previously agentEnabled determined behavior (agent mode sent only file paths for lightweight context, ask mode included full file content), but this change removes that branching and now always processes and sends file content, which may impact performance and alter expected agent-mode behavior.
Collaborator
Author
|
Uh... yes you are right, as it is, it does not make sense. I will fix it. What do you think of the most general question about sending everything in ask mode? It seems still dangerous to me... |
Collaborator
Author
|
I have created #319 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wasn't able to reproduce the issue, it may be due to additional extensions given to the configuration. However, the bug is there and this PR proposes the fix.
In looking at the code and doing some experiments, though, I believe we should not send all files in Ask mode neither: if you do open a chat in ask mode with Jeddict-ai project you saturate the context window right away.