Fix for #309 prompt /rest gets fired even if the rest part is inbedded in other text#313
Merged
Conversation
…ns implemented were not working. The good news is that being able to reproduce the issue, I am now more confident of the fix. Replacing the factory service is not enough to guarantee the right classloader is used in module registration. The solution is to decouple service creation from module registration and force the classloader in the latter.
…t is inbedded in other text
…_Prompt_rest-gets_fired_even_if_the_rest-part_is_inbedded_in_other_text
…t is inbedded in other text
stefanofornari
changed the title
jGauravGupta
approved these changes
Mar 22, 2026
stefanofornari
deleted the
ste/fix/309_Prompt_rest-gets_fired_even_if_the_rest-part_is_inbedded_in_other_text
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.