plan 89: address Copilot review on PR #147

[jeduden]

Summary

Follow-up to PR #147 (already merged). Addresses six Copilot review threads on the plan 89 document that were not resolved before merge.

Changes

• Renumber MDS036 → MDS037 for the toc rule. Plan 51 (PR plan 51: add MDS036 section-size-limits rule #143) merged first and took MDS036 for max-section-length. MDS034 remains reserved for plan 86.
• Reuse existing slug logic. Instead of a new hand-rolled algorithm, require moving slugify and the duplicate-anchor counter out of internal/rules/crossfilereferenceintegrity/ into a shared helper (internal/mdtext/) that both rules call. Drops the incorrect goldmark-meta reference.
• Drop <?listindent?> — it is not a real directive. Describe list indentation in terms of MDS016 list-indent.spaces (default 2).
• Correct MDS015 interaction note. MDS015 enforces blank lines around fenced code blocks only; padding around <?toc?> is MDS035 Fix's responsibility.
• Unify the canonical empty-body form as <?toc?>\n<?/toc?> everywhere (design, tasks, acceptance criteria).
• Add a prerequisite task to move the slug helper to the shared package and renumber downstream tasks.
• Grammar pass: "GitHub-style" consistently.

Test plan

• mdsmith check . passes
• Plan doc re-reads consistently (rule ID, empty-body format, references)

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.76%. Comparing base (7958dcd) to head (6a6db67).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #148   +/-   ##
=======================================
  Coverage   86.76%   86.76%           
=======================================
  Files          96       96           
  Lines       10446    10446           
=======================================
  Hits         9063     9063           
  Misses        900      900           
  Partials      483      483           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

Pull request overview

Updates plan 89’s specification for the upcoming <?toc?>...<?/toc?> directive and related MDS035 fix behavior, aligning it with current rule numbering and existing anchor/slug logic used elsewhere in mdsmith.

Changes:

• Renumbers the planned TOC rule from MDS036 → MDS037 and documents the numbering rationale.
• Specifies reusing (and extracting) existing heading-anchor slug/disambiguation logic from crossfilereferenceintegrity into a shared helper under internal/mdtext/.
• Removes/clarifies incorrect directive and rule-interaction details (no <?listindent?>, MDS015 scope, canonical empty <?toc?> block form).

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

[jeduden]

🟢 Merge Queue — picked up

This PR is in the queue and will be batched with other queue-labelled PRs.

Next: No action needed — you'll get another comment when CI starts on the batch. View merge queue run.

[jeduden]

🔵 Merge Queue — CI running

Merged into batch branch merge-queue/batch-148-1776700679. View CI run.

Next: No action needed — you'll be notified when CI completes.

[jeduden]

✅ Merge Queue — merged

This PR landed on main via commit 3291efc. CI run that validated the merge.

Next: Done — nothing more to do here.