Skip to content

Simplify merge queue workflow configuration #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeduden merged 3 commits into from
Apr 26, 2026
Merged

Simplify merge queue workflow configuration #173

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6118d6f
ci: bump merge-queue-action to v0.7.0
claude Apr 26, 2026
8cea460
ci: bump merge-queue-action to v0.7.1
claude Apr 26, 2026
82a1f35
ci: restore MERGE_QUEUE_TOKEN in checkout for git push auth
claude Apr 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 3 additions & 23 deletions .github/workflows/merge-queue.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
name: Merge Queue

# Dummy change to test merge queue action.

on:
pull_request:
types: [labeled]
Expand All @@ -18,37 +16,19 @@ concurrency:
group: merge-queue
cancel-in-progress: false

permissions: {}

jobs:
queue:
Comment thread
jeduden marked this conversation as resolved.
if: >-
github.event_name == 'workflow_dispatch' ||
(github.event.label.name == 'queue' &&
github.event.pull_request.base.ref == 'main' &&
github.event.pull_request.head.repo.full_name == github.repository)
runs-on: ubuntu-latest
permissions:
contents: write
pull-requests: write
actions: write
issues: write
steps:
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
fetch-depth: 0
Comment thread
jeduden marked this conversation as resolved.
token: ${{ secrets.MERGE_QUEUE_TOKEN }}
persist-credentials: false

- name: Configure git identity
run: |
git config user.email "merge-queue@users.noreply.github.com"
git config user.name "merge-queue-bot"

- uses: jeduden/merge-queue-action@5adb5a76e27e96f1da5efd36f097a2c5233e9ad3 # v0.6.0
- uses: jeduden/merge-queue-action@3be8077b142e4057d2fc097635d1ab6ada2bbbf5 # v0.7.1
with:
token: ${{ secrets.MERGE_QUEUE_TOKEN }}
Comment on lines 26 to 30

Copilot AI Apr 26, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description says the action was updated to v0.7.0, but the workflow pins v0.7.1 here. Also, the description mentions removing the checkout token, but actions/checkout still uses secrets.MERGE_QUEUE_TOKEN. Please align the PR description with what’s actually changed (or adjust the workflow if the intent was different).

Copilot uses AI. Check for mistakes.
ci_workflow: .github/workflows/ci.yml
batch_size: "5"
bisect: ${{ github.event.inputs.bisect || false }}
batch_prs: ${{ github.event.inputs.batch_prs || '' }}
bisect: ${{ github.event.inputs.bisect }}
batch_prs: ${{ github.event.inputs.batch_prs }}
Comment thread
jeduden marked this conversation as resolved.
Comment on lines +33 to +34

Copilot AI Apr 26, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bisect and batch_prs are now always passed as ${{ github.event.inputs.* }}. For pull_request events, github.event.inputs is not defined, so these will evaluate to an empty value that can override the action’s defaults (and potentially break boolean parsing). Consider restoring the explicit fallbacks (|| false / || '') or otherwise ensuring these inputs are only set for workflow_dispatch runs.

Suggested change
bisect: ${{ github.event.inputs.bisect }}
batch_prs: ${{ github.event.inputs.batch_prs }}
bisect: ${{ github.event.inputs.bisect || false }}
batch_prs: ${{ github.event.inputs.batch_prs || '' }}

Copilot uses AI. Check for mistakes.
Loading