Skip to content

audit(arch): 2026-06-24 sweep (09f22d3..3d35b77); add plans 2606241814-15 - #696

Merged
jeduden merged 2 commits into
mainfrom
claude/youthful-knuth-ck4zdk
Jun 25, 2026
Merged

audit(arch): 2026-06-24 sweep (09f22d3..3d35b77); add plans 2606241814-15#696
jeduden merged 2 commits into
mainfrom
claude/youthful-knuth-ck4zdk

Conversation

@jeduden

@jeduden jeduden commented Jun 24, 2026

Copy link
Copy Markdown
Owner

Summary

  • Appends the architecture audit for range 09f22d3..3d35b77 to docs/development/architecture-audit.md
  • No blockers, DIP/SRP/line-count violations in this range
  • Two tax items filed as new plan files

New plans

  • plan/2606241814internal/lsp/rename.go: add dedicated unit tests for prepareRenameAt, renameHeading, renameLinkRef, and lspRenameWorkspace.Resolve; add // no test by design to two trivial one-liners
  • plan/2606241815internal/index/locate.go: add TestPiContainsLine, TestRefDefOnLine, and TestLocateInFrontMatter (three helpers omitted from plan 2606240211); add // no test by design to isGlobPattern

Test plan

  • mdsmith check . — 0 failures (516 files checked)
  • Plans 2606241814 and 2606241815 will be implemented in follow-up PRs

Generated by Claude Code

claude added 2 commits June 24, 2026 18:23
…4-15

Appends the architecture audit for range 09f22d3..3d35b77. No blockers,
no DIP/SRP/line-count violations. Two tax items filed as new plan files:
plan 2606241814 (lsp/rename dispatch test debt) and plan 2606241815
(three remaining locate helper tests + isGlobPattern exemption).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017B6UozraSTtpwVqW2PMoFV
…ateInFrontMatter

Closes plan 2606241815. Adds dedicated unit tests for the three
unexported helpers in internal/index/locate.go that were omitted from
plan 2606240211. isGlobPattern already carries its "no test by design"
exemption comment.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017B6UozraSTtpwVqW2PMoFV
@codecov

codecov Bot commented Jun 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.62%. Comparing base (3d35b77) to head (05db2ca).

Additional details and impacted files
Components Coverage Δ
Go 98.61% <ø> (ø)
TypeScript 99.54% <ø> (ø)

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

jeduden pushed a commit that referenced this pull request Jun 25, 2026
@jeduden

jeduden commented Jun 25, 2026

Copy link
Copy Markdown
Owner Author

🔍 Merge Queue — bisecting

A larger batch failed CI. Bisection is isolating the culprit: this run tests up to 3 of 5 candidate PRs on merge-queue/batch-bisect-693-1782413840. View current bisect CI run.

Next: No action needed — you'll be notified when the culprit is isolated, this PR merges, or this PR returns to the queue for a later batch.

@jeduden

jeduden commented Jun 25, 2026

Copy link
Copy Markdown
Owner Author

🔍 Merge Queue — bisecting

A larger batch failed CI. Bisection is isolating the culprit: this run tests up to 2 of 3 candidate PRs on merge-queue/batch-bisect-693-1782414277. View current bisect CI run.

Next: No action needed — you'll be notified when the culprit is isolated, this PR merges, or this PR returns to the queue for a later batch.

@jeduden jeduden added queue:attempt-1 queue Add to a PR to enqueue it labels Jun 25, 2026
@jeduden

jeduden commented Jun 25, 2026

Copy link
Copy Markdown
Owner Author

Merge Queue — requeued

The merge queue hit a transient error while processing this PR:

bisection continues on a smaller batch; this PR was not tested and returned to the queue

View merge queue run.

Next: No action needed — the queue will retry automatically on the next run.

@jeduden jeduden removed queue Add to a PR to enqueue it queue:attempt-1 labels Jun 25, 2026
@jeduden

jeduden commented Jun 25, 2026

Copy link
Copy Markdown
Owner Author

🔍 Merge Queue — bisecting

A larger batch failed CI. Bisection is isolating the culprit: this run tests up to 2 of 3 candidate PRs on merge-queue/batch-bisect-696-1782420299. View current bisect CI run.

Next: No action needed — you'll be notified when the culprit is isolated, this PR merges, or this PR returns to the queue for a later batch.

@jeduden

jeduden commented Jun 25, 2026

Copy link
Copy Markdown
Owner Author

Merge Queue — merged

This PR landed on main via commit 510e6a2. CI run that validated the merge.

Next: Done — nothing more to do here.

@jeduden
jeduden merged commit 4d02e42 into main Jun 25, 2026
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants