Skip to content

test(lint): add dedicated unit tests for 9 lineclass_scan HTML helpers (plan 2606260614) - #702

Merged
jeduden merged 5 commits into
mainfrom
claude/youthful-knuth-moh023
Jun 26, 2026
Merged

test(lint): add dedicated unit tests for 9 lineclass_scan HTML helpers (plan 2606260614)#702
jeduden merged 5 commits into
mainfrom
claude/youthful-knuth-moh023

Conversation

@jeduden

@jeduden jeduden commented Jun 26, 2026

Copy link
Copy Markdown
Owner

Summary

  • Architecture audit sweep (range 3d35b77..fe7141b) filed two new tax plans: 2606260614 (lineclass_scan helpers) and 2606260615 (cuelite engine helpers).
  • Implements plan 2606260614: adds 9 dedicated unit tests in internal/lint/lineclass_scan_test.go for the unexported HTML-scanning sub-functions of htmlType7Start.

Tests added

TestScanHTMLTag, TestScanClosingTag, TestScanOpenTag, TestScanTagName, TestScanAttribute, TestScanAttrValue, TestSkipHTMLWS, TestIsUnquotedStop, TestEqualFoldASCII — each covers the happy path and key failure arms. No production code changed.

Test plan

  • go test ./internal/lint/... green
  • go vet ./... clean
  • go run ./cmd/mdsmith check docs/development/architecture-audit.md passes
  • Plan 2606260614 status → ✅

🤖 Generated with Claude Code

https://claude.ai/code/session_01VwsEmnkHJvLoaj8imqQRjJ

Generated by Claude Code

@codecov

codecov Bot commented Jun 26, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.62%. Comparing base (a29c423) to head (885d2f0).

Additional details and impacted files
Components Coverage Δ
Go 98.61% <ø> (ø)
TypeScript 99.54% <ø> (ø)

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

jeduden pushed a commit that referenced this pull request Jun 26, 2026
merge-queue-bot
Merge PR #702: test(lint): add dedicated unit tests for 9 lineclass_s…
6ded0a1 
…can HTML helpers (plan 2606260614)
@jeduden

jeduden commented Jun 26, 2026

Copy link
Copy Markdown
Owner Author

🔍 Merge Queue — bisecting

A larger batch failed CI. Bisection is isolating the culprit: this run tests up to 2 of 3 candidate PRs on merge-queue/batch-bisect-701-1782479238. View current bisect CI run.

Next: No action needed — you'll be notified when the culprit is isolated, this PR merges, or this PR returns to the queue for a later batch.

@jeduden

jeduden commented Jun 26, 2026

Copy link
Copy Markdown
Owner Author

🔍 Merge Queue — bisecting

A larger batch failed CI. Bisection is isolating the culprit: this run tests up to 1 of 2 candidate PRs on merge-queue/batch-bisect-701-1782479629. View current bisect CI run.

Next: No action needed — you'll be notified when the culprit is isolated, this PR merges, or this PR returns to the queue for a later batch.

jeduden pushed a commit that referenced this pull request Jun 26, 2026
merge-queue-bot
Merge PR #702: test(lint): add dedicated unit tests for 9 lineclass_s…
67e6634 
…can HTML helpers (plan 2606260614)
@jeduden

jeduden commented Jun 26, 2026

Copy link
Copy Markdown
Owner Author

🔍 Merge Queue — bisecting

A larger batch failed CI. Bisection is isolating the culprit: this run tests up to 1 of 1 candidate PRs on merge-queue/batch-bisect-702-1782479991. View current bisect CI run.

Next: No action needed — you'll be notified when the culprit is isolated, this PR merges, or this PR returns to the queue for a later batch.

@jeduden jeduden added the queue:failed Applied automatically when CI fails or merge conflict occurs label Jun 26, 2026
@jeduden

jeduden commented Jun 26, 2026

Copy link
Copy Markdown
Owner Author

❌ Merge Queue — CI failed (identified via bisection)

Bisection identified this PR as the failing change. View CI run that isolated the failure.

Next: Fix the failure, push updates, then re-add the queue label to retry.

claude added 5 commits June 26, 2026 13:27
@claude
audit: sweep 3d35b77..fe7141b; add plans 2606260614 and 2606260615
82a833d 
Closes the 2026-06-26 architecture audit. Two tax items filed:
- internal/lint/lineclass_scan.go: 9 unexported HTML-scanning helpers
  lack dedicated unit tests (plan/2606260614).
- cue/cuelite/engine.go: 7 unexported helpers lack dedicated unit
  tests (plan/2606260615).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VwsEmnkHJvLoaj8imqQRjJ
@claude
test(lint): add dedicated tests for 9 lineclass_scan HTML helpers (pl…
0e04b43 
…an 2606260614)

TestScanHTMLTag, TestScanClosingTag, TestScanOpenTag, TestScanTagName,
TestScanAttribute, TestScanAttrValue, TestSkipHTMLWS, TestIsUnquotedStop,
TestEqualFoldASCII — each covers the happy path and key failure arms.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VwsEmnkHJvLoaj8imqQRjJ
@claude
chore: refresh PLAN.md catalog (plan 2606260614 now ✅)
bf31eb3 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VwsEmnkHJvLoaj8imqQRjJ
@claude
fix: address code-review findings on lineclass_scan test PR
112142b 
- Remove stale IncomingAnchorEdges audit entry (exemption already
  present at internal/lsp/rename.go:437)
- Add internal/rules/listscan to the approved-helpers list in the
  architecture hub and audit checklist, restoring the clearance that
  was deleted when the 2026-06-21 audit entry was compressed
- Add TestContainsFold directly testing the sliding-window
  case-insensitive searcher (boundary cases: match at pos 0, middle,
  last window; no match; needle longer than line; empty line)
- Add end-of-input success case to TestScanTagName

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VwsEmnkHJvLoaj8imqQRjJ
@claude
fix: shorten layer0_html.go audit entry to pass MDS023 readability
885d2f0 
The inline function-name list made the bullet's average sentence
length exceed the 14-word readability budget. Drop the list; the
function names are already documented in plan/2606260211.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VwsEmnkHJvLoaj8imqQRjJ
@jeduden
jeduden force-pushed the claude/youthful-knuth-moh023 branch from 475e8b2 to 885d2f0 Compare June 26, 2026 13:30
@jeduden jeduden added queue Add to a PR to enqueue it and removed queue:failed Applied automatically when CI fails or merge conflict occurs labels Jun 26, 2026 — with Claude
@jeduden jeduden added queue:active Applied automatically when a PR is in an active batch and removed queue Add to a PR to enqueue it labels Jun 26, 2026
@jeduden

jeduden commented Jun 26, 2026

Copy link
Copy Markdown
Owner Author

🟢 Merge Queue — picked up

This PR is in the queue and will be batched with other queue-labelled PRs.

Next: No action needed — you'll get another comment when CI starts on the batch. View merge queue run.

jeduden pushed a commit that referenced this pull request Jun 26, 2026
merge-queue-bot
Merge PR #702: test(lint): add dedicated unit tests for 9 lineclass_s…
15570e1 
…can HTML helpers (plan 2606260614)
@jeduden

jeduden commented Jun 26, 2026

Copy link
Copy Markdown
Owner Author

🔵 Merge Queue — CI running

Merged into batch branch merge-queue/batch-702-1782480687 alongside #703. View CI run.

Next: No action needed — you'll be notified when CI completes.

@jeduden jeduden mentioned this pull request Jun 26, 2026
Merged
4 tasks
@jeduden

jeduden commented Jun 26, 2026

Copy link
Copy Markdown
Owner Author

🔍 Merge Queue — bisecting

A larger batch failed CI. Bisection is isolating the culprit: this run tests up to 1 of 2 candidate PRs on merge-queue/batch-bisect-702-1782481064. View current bisect CI run.

Next: No action needed — you'll be notified when the culprit is isolated, this PR merges, or this PR returns to the queue for a later batch.

@jeduden jeduden removed the queue:active Applied automatically when a PR is in an active batch label Jun 26, 2026
@jeduden
jeduden merged commit 2e5c3d4 into main Jun 26, 2026
36 checks passed
@jeduden

jeduden commented Jun 26, 2026

Copy link
Copy Markdown
Owner Author

✅ Merge Queue — merged

This PR landed on main via commit 2e5c3d4. CI run that validated the merge.

Next: Done — nothing more to do here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jeduden @claude