Skip to content

docs(security): 2026-07-31 post-audit diff review — no new findings - #781

Draft
jeduden wants to merge 1 commit into
mainfrom
claude/youthful-sagan-d2avjk
Draft

docs(security): 2026-07-31 post-audit diff review — no new findings#781
jeduden wants to merge 1 commit into
mainfrom
claude/youthful-sagan-d2avjk

Conversation

@jeduden

@jeduden jeduden commented Jul 31, 2026

Copy link
Copy Markdown
Owner

Summary

Scheduled weekly post-audit security diff review, covering everything merged since the 2026-07-24 review (base d4af5d5 → HEAD 2ab4b29, 98 files). Adds the review artifacts under docs/security/2026-07-31-post-audit-diff-review/ (findings.json / report.md / findings.sarif / inline-annotations.json) and regenerates the SECURITY.md catalog.

Verdict: no new security findings. report.md records 0 across all severities.

What the window contained

  • Overwhelmingly semantic-preserving perf refactoring (struct-field reordering, byte-scan gating, memoization), test additions, and doc/merge-driver correctness fixes.
  • Two content-only rules: MDS060 occurrence (compiles config-supplied patterns with Go RE2 — linear-time, no ReDoS; no exec/network/path sink) and MDS073 slidev-structure follow-up (rule already reviewed 2026-07-24).

§0 baseline reconfirmed

  • No new exec/network/spawn sink anywhere in the diff — the only grep hits are the prose of last week's own MDS072 report. Recipes still not executed by the tool.
  • Every filesystem/path sink added in the diff is in _test.go files, except a githooks refactor that resolves an unchanged git rev-parse hooks dir once instead of twice (no path/symlink semantics changed).
  • The include directive, goldmark parser, foreignregion scan, and crossfile glob-validation changes are all semantic-preserving perf refactors (verified equivalence in the report).

Net security hardening this window

  • internal/corpus/collect.go: caps read size and closes a Stat→read TOCTOU, skipping oversized/racy files instead of aborting the corpus build.
  • internal/lint/file.go ColumnOfOffset: adds a negative-offset clamp and switches to the cached newline binary search.

Carried over (out of scope this window)

The MDS072 external-link-check SSRF finding (S001 of 2026-07-24) remains openinternal/rules/externallink/ was untouched, and its fix plan plan/2607242010_mds072-ssrf-network-hardening.md is still open. Not re-filed here to avoid duplicate tracking. No new plans were filed because there were no new actionable findings.

🤖 Generated with Claude Code

https://claude.ai/code/session_01UTLab5Xq2pxqWDVqP9rbSq


Generated by Claude Code

Diff review of the 98 files merged since the 2026-07-24 review
(base d4af5d5 -> HEAD 2ab4b29). No new security findings.

The window is overwhelmingly semantic-preserving perf refactoring
(struct-field reordering, byte-scan gating, memoization), test
additions, doc/merge-driver correctness fixes, and two content-only
rules (MDS060 occurrence, MDS073 slidev follow-up).

§0 baseline reconfirmed: no new exec/network/spawn sink anywhere in
the diff; recipes still not executed; every fs/path sink added is in
test files except a githooks refactor resolving an unchanged
git-rev-parse hooks dir once instead of twice. Two changes are net
security hardening (corpus read-size cap + Stat->read TOCTOU close;
ColumnOfOffset negative-offset clamp). MDS060 compiles config-supplied
patterns with Go RE2 (no ReDoS).

The MDS072 external-link-check SSRF finding (S001 of 2026-07-24)
remains open and out of scope this window — externallink code was
untouched and plan 2607242010 is still open.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UTLab5Xq2pxqWDVqP9rbSq
@codecov

codecov Bot commented Jul 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.71%. Comparing base (2ab4b29) to head (9e7374c).

Additional details and impacted files
Components Coverage Δ
Go 98.70% <ø> (ø)
TypeScript 99.54% <ø> (ø)

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants