Fix duplicate position parameter in log::getDelta call - #3120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Cette PR corrige un problème détecté par PHPStan dans jeeApi.php : l'appel à
log::getDelta()passait le paramètre$params['position']deux fois, ne correspondant pas à la signature de la méthode.La signature de
log::getDelta()attend 7 paramètres :$_log$_position$_search$_colored$_numbered$_numStart$_maxMais l'appel passait 8 paramètres avec
$params['position']en double (positions 2 et 4), ce qui décalait tous les paramètres suivants et causait un mauvais mapping des arguments.Le correctif supprime le paramètre
$params['position']en double pour respecter la signature de la méthode.Suggested changelog entry
Correction d'un paramètre en double dans l'appel à log::getDelta dans jeeApi.php
Related issues/external references
N/A
Types of changes
PR checklist