patch: remove nginx support - #3376
Merged
Merged
Conversation
Jeedom only supports Apache, so the leftover nginx artefacts are removed: - delete the install/nginx_default vhost template - drop the nginx.error handling in log::canRemoveLog() (http.error kept) - remove the now-irrelevant nginx_default CORS regression test - fix the FAQ restore path /usr/share/nginx/www/jeedom -> /var/www/html (Apache path already used everywhere else) and the matching i18n keys Closes #3331
Mips2648
requested changes
Jun 23, 2026
Mips2648
left a comment
Mips2648
left a comment
Collaborator
There was a problem hiding this comment.
Hi,
Please review changes done by AI before submitting PR: as far as I know, we are not supposed to modify translations files.
Per review: translation files (docs/i18n/*.json and the non-French docs/*/faq.md) are managed by the translation workflow and must not be edited by hand. Revert them; only the French source docs/fr_FR/faq.md keeps the nginx -> apache path fix.
Contributor
Author
|
Bonjour @Mips2648, tu as raison — merci. J'ai retiré toutes les modifications des fichiers de traduction : Le PR ne contient désormais que :
La propagation vers les autres langues se fera via le workflow de traduction habituel. Generated by Claude Code |
Mips2648
approved these changes
Jun 23, 2026
Salvialf
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Résumé
Jeedom ne fonctionne plus qu'avec Apache (et plus avec nginx). Cette PR retire les vestiges liés à nginx dans le code, la configuration et la documentation du core.
Changements
install/nginx_default: suppression du template de vhost nginx.core/class/log.class.php:log::canRemoveLog()ne protège plus le fichiernginx.error(la protection dehttp.errorest conservée).tests/corsHeadersTest.php: suppression du testtestNginxDefaultHasNoAllowCredentials()devenu sans objet (les tests.htaccessetjeeApi.phprestent).docs/*/faq.md, 5 langues) : correction du chemin de la procédure de restauration BDD/usr/share/nginx/www/jeedom→/var/www/html, le chemin Apache déjà utilisé partout ailleurs dans ces mêmes FAQ. Clés de traduction correspondantes mises à jour dansdocs/i18n/*.json.Hors périmètre
Les occurrences de « nginx » dans
3rdparty/(mode de coloration nginx de CodeMirror, elFinder) sont laissées intactes : ce sont des bibliothèques tierces vendored, sans rapport avec le support nginx de Jeedom.Vérifications
php -lOK sur les fichiers PHP modifiés.docs/i18n/*.jsonrestent du JSON valide.nginxhors3rdparty/.Closes #3331
Generated by Claude Code