Use guard clauses in cmd->addHistoryValue - #3400
Merged
Merged
Conversation
Mips2648
approved these changes
Jun 27, 2026
Sekiro-kost
approved these changes
Jun 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ifblock inaddHistoryValuewith early return guard clausesreturnonhistory::save()(returns void)$_unite_conversionPHPDoc type fromarray<string, int|string>toarray<string, array<int|string>>Motivation
The original method wrapped its entire body in one deeply nested condition, making it hard to follow the validation logic. The guard clause pattern makes each rejection reason explicit and reduces indentation throughout the method body.
This refactor is also preparatory for an upcoming history retention feature that will add logic between the guards and the history save.
Behaviour
No functional change.
history::save()already rejects null values internally (early return on line 1012), so dropping the null pass-through from the outer condition has no observable effect.