Modernize Element.prototype.empty using replaceChildren - #3417
Merged
Conversation
- Replaces the manual while/removeChild loop with the native replaceChildren() call - Clears all children in a single DOM operation instead of one removeChild per node
zoic21
approved these changes
Jul 8, 2026
Mips2648
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the manual
while (this.firstChild) { this.removeChild(this.lastChild) }loop with the nativereplaceChildren()method.This clears all children in a single DOM operation instead of one
removeChildcall per node, and is consistent with other modern DOM APIs already used in this file (closest,Array.from, optional chaining).