Fire real click/change events when toggling checkboxes via the context menu - #3427
Merged
Conversation
zoic21
approved these changes
Jul 17, 2026
…r single-line conditions
Mips2648
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jeedomUtils.setCheckboxStateByTypetoggledcheckbox.checkedby direct property assignment, which never fires any nativeclickorchangeevent. Any listener depending on those events to react to a checkbox toggle was silently bypassed when the toggle came from the checkbox context menu (select all / none / invert), only a direct user click on the checkbox worked correctly.checkbox.click(), which both toggles the state and fires realclick/changeevents, indistinguishable from genuine user interaction._callbackparameter fromsetCheckContextMenu/setCheckboxStateByType: display.js was the only caller using it, to manually fire achangeevent, which.click()now does natively. administration.js and plan.configure.php were relying on no callback at all and had the same latent bug, now fixed as a side effect.