Skip to content

Fire real click/change events when toggling checkboxes via the context menu - #3427

Merged
Salvialf merged 4 commits into
developfrom
fix/checkbox-contextMenu-events
Jul 22, 2026
Merged

Fire real click/change events when toggling checkboxes via the context menu#3427
Salvialf merged 4 commits into
developfrom
fix/checkbox-contextMenu-events

Conversation

@Salvialf

Copy link
Copy Markdown
Contributor
  • jeedomUtils.setCheckboxStateByType toggled checkbox.checked by direct property assignment, which never fires any native click or change event. Any listener depending on those events to react to a checkbox toggle was silently bypassed when the toggle came from the checkbox context menu (select all / none / invert), only a direct user click on the checkbox worked correctly.
  • Switched to checkbox.click(), which both toggles the state and fires real click/change events, indistinguishable from genuine user interaction.
  • Removed the now-unneeded _callback parameter from setCheckContextMenu/setCheckboxStateByType: display.js was the only caller using it, to manually fire a change event, which .click() now does natively. administration.js and plan.configure.php were relying on no callback at all and had the same latent bug, now fixed as a side effect.

@Salvialf Salvialf added the changelog-other Use to generate release notes label Jul 16, 2026
@Salvialf
Salvialf merged commit 94cc916 into develop Jul 22, 2026
9 checks passed
@Salvialf
Salvialf deleted the fix/checkbox-contextMenu-events branch July 22, 2026 16:33
@Salvialf Salvialf added changelog-fix Use to generate release notes / changelog To be apply on PR and removed changelog-other Use to generate release notes labels Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog-fix Use to generate release notes / changelog To be apply on PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants