Fix broken translations on the update page - #3431
Merged
Merged
Conversation
Salvialf
added
Need approval
changelog-fix
zoic21
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The recent update page harmonization (#3426) introduced several translation regressions:
logicalId,type) inside the{{ }}translation markers instead of outside, so the raw JS concatenation syntax was captured as literal text to translate instead of a clean sentence.{{ }}block. The translation system only escapes single quotes in translated text, so any translation containing a literal"(as happened for the English "Information" and "Save" strings) broke the JS parsing or the surrounding HTML attribute.This PR restores the correct
{{ }}usage (fixed text only, variables outside the markers) and reverts to single-quoted JS strings where{{ }}is used, matching the convention used everywhere else in the codebase. It also drops an ambiguous parenthetical from the "do not update this plugin" tooltip that was prompting the translator to add quotes around "Save", which broke thetitle="..."attribute.