refactor(lib): merge rt, geometry and scene submodules into geometry#498
refactor(lib): merge rt, geometry and scene submodules into geometry#498jeertmans wants to merge 1 commit into
rt, geometry and scene submodules into geometry#498Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #498 +/- ##
==========================================
+ Coverage 88.55% 88.58% +0.02%
==========================================
Files 33 32 -1
Lines 4012 4012
==========================================
+ Hits 3553 3554 +1
+ Misses 459 458 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ea1e600 to
71d5f02
Compare
71d5f02 to
3df7022
Compare
github-actions
Bot
added
documentation
3df7022 to
844d476
Compare
Merging this PR will not alter performance
Comparing 
Footnotes
|
844d476 to
d1148b7
Compare
d1148b7 to
935486d
Compare
935486d to
20bb5fe
Compare
20bb5fe to
5051c44
Compare
5051c44 to
c98b2b0
Compare
c98b2b0 to
f7d0943
Compare
| ... tx = jnp.array([0.0, 0.0, 0.0]) | ||
| ... key = jax.random.key(1234) | ||
| ... draw_markers(tx.reshape(-1, 3), labels=["tx"], showlegend=False) | ||
| ... _ = draw_markers(tx.reshape(-1, 3), labels=["tx"], showlegend=False) |
There was a problem hiding this comment.
I don't think that we should promote this pattern, so let's revert back to not using any variable assignment. If needed, let's skip doctests. Applies here an everywhere else.
| ... center = mesh.bounding_box.mean(axis=0) | ||
| ... mesh = mesh.translate(5 * (center - tx)).set_face_colors(color) | ||
| ... mesh.plot(opacity=0.5) | ||
| ... mesh = mesh.translate(5 * (center - tx)).set_face_colors( |
There was a problem hiding this comment.
Maybe we should document the difference between [1,0] rgba and [0,255] RGBA, as we maybe support both.
| o3d_mesh = o3d.io.read_triangle_mesh(knot_mesh.path).translate([50, 20, 10]) | ||
|
|
||
| o3d_mesh = o3d.t.geometry.Mesh.from_legacy(o3d_mesh) | ||
| o3d_mesh = o3d.t.geometry.TriangleMesh.from_legacy(o3d_mesh) |
There was a problem hiding this comment.
I don't remember why we even needed to do this, but we should maybe remove this line entirely.
There was a problem hiding this comment.
| @@ -58,6 +58,8 @@ with one *slight* but **important** difference: | |||
| - **Breaking change**: Mask and intersection type arrays of path classes are no longer optional (by <gh-user:jeertmans>, in <gh-pr:491>). | |||
| - **Breaking change**: Renamed `TriangleMesh` to {class}`Mesh<differt.geometry.Mesh>` and `TriangleScene` to {class}`Scene<differt.scene.Scene>` across the codebase. Deprecated aliases are provided for backwards compatibility, raising a `DeprecationWarning` when used (by <gh-user:jeertmans>, in <gh-issue:496>). | |||
|
|
|||
f7d0943 to
f916792
Compare
f916792 to
8b38fa2
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| "outputs": [], | ||
| "source": [ | ||
| "from differt.scene import Scene\n", | ||
| "from differt.geometry import Scene\n", |
There was a problem hiding this comment.
[LanguageTool] reported by reviewdog 🐶
If a new sentence starts here, add a space and start with an uppercase letter. (LC_AFTER_PERIOD[1])
Suggestions: Geometry, geometry
Rule: https://community.languagetool.org/rule/show/LC_AFTER_PERIOD?lang=en-US&subId=1
Category: CASING
| "from differt.plotting import draw_paths, set_backend\n", | ||
| "from differt.rt import fermat_path_on_linear_objects\n", | ||
| "from differt.scene import Scene" | ||
| "from differt.geometry import (\n", |
There was a problem hiding this comment.
[LanguageTool] reported by reviewdog 🐶
If a new sentence starts here, add a space and start with an uppercase letter. (LC_AFTER_PERIOD[1])
Suggestions: Geometry, geometry
Rule: https://community.languagetool.org/rule/show/LC_AFTER_PERIOD?lang=en-US&subId=1
Category: CASING
| " assemble_path,\n", | ||
| " fermat_path_on_linear_objects,\n", | ||
| ")\n", | ||
| "from differt.plotting import draw_paths, set_backend" |
There was a problem hiding this comment.
[LanguageTool] reported by reviewdog 🐶
If a new sentence starts here, add a space and start with an uppercase letter. (LC_AFTER_PERIOD[1])
Suggestions: Plotting, plotting
Rule: https://community.languagetool.org/rule/show/LC_AFTER_PERIOD?lang=en-US&subId=1
Category: CASING
| "outputs": [], | ||
| "source": [ | ||
| "from differt.scene import download_sionna_scenes, get_sionna_scene\n", | ||
| "from differt.geometry import download_sionna_scenes, get_sionna_scene\n", |
There was a problem hiding this comment.
[LanguageTool] reported by reviewdog 🐶
If a new sentence starts here, add a space and start with an uppercase letter. (LC_AFTER_PERIOD[1])
Suggestions: Geometry, geometry
Rule: https://community.languagetool.org/rule/show/LC_AFTER_PERIOD?lang=en-US&subId=1
Category: CASING
| "\n", | ||
| "import jax\n", | ||
| "from differt.rt import ray_intersect_triangle\n", | ||
| "from differt.geometry import ray_intersect_triangle\n", |
There was a problem hiding this comment.
[LanguageTool] reported by reviewdog 🐶
If a new sentence starts here, add a space and start with an uppercase letter. (LC_AFTER_PERIOD[1])
Suggestions: Geometry, geometry
Rule: https://community.languagetool.org/rule/show/LC_AFTER_PERIOD?lang=en-US&subId=1
Category: CASING
| "import equinox as eqx\n", | ||
| "import jax.numpy as jnp\n", | ||
| "from differt.scene import (\n", | ||
| "from differt.geometry import (\n", |
There was a problem hiding this comment.
[LanguageTool] reported by reviewdog 🐶
If a new sentence starts here, add a space and start with an uppercase letter. (LC_AFTER_PERIOD[1])
Suggestions: Geometry, geometry
Rule: https://community.languagetool.org/rule/show/LC_AFTER_PERIOD?lang=en-US&subId=1
Category: CASING
| "import jax.numpy as jnp\n", | ||
| "from differt.geometry import Mesh\n", | ||
| "from differt.scene import Scene\n", | ||
| "from differt.geometry import Mesh, Scene\n", |
There was a problem hiding this comment.
[LanguageTool] reported by reviewdog 🐶
If a new sentence starts here, add a space and start with an uppercase letter. (LC_AFTER_PERIOD[1])
Suggestions: Geometry, geometry
Rule: https://community.languagetool.org/rule/show/LC_AFTER_PERIOD?lang=en-US&subId=1
Category: CASING
| "from differt.scene import (\n", | ||
| " Scene,\n", | ||
| ")" | ||
| "from differt.plotting import draw_image, reuse, set_backend" |
There was a problem hiding this comment.
[LanguageTool] reported by reviewdog 🐶
If a new sentence starts here, add a space and start with an uppercase letter. (LC_AFTER_PERIOD[1])
Suggestions: Plotting, plotting
Rule: https://community.languagetool.org/rule/show/LC_AFTER_PERIOD?lang=en-US&subId=1
Category: CASING
|
|
||
| ```python | ||
| from differt.scene import ExhaustivePathTracer | ||
| from differt.geometry import ExhaustivePathTracer |
There was a problem hiding this comment.
[LanguageTool] reported by reviewdog 🐶
If a new sentence starts here, add a space and start with an uppercase letter. (LC_AFTER_PERIOD[1])
Suggestions: Geometry, geometry
Rule: https://community.languagetool.org/rule/show/LC_AFTER_PERIOD?lang=en-US&subId=1
Category: CASING
|
|
||
| ```python | ||
| from differt.scene import SBRPathLauncher | ||
| from differt.geometry import SBRPathLauncher |
There was a problem hiding this comment.
[LanguageTool] reported by reviewdog 🐶
If a new sentence starts here, add a space and start with an uppercase letter. (LC_AFTER_PERIOD[1])
Suggestions: Geometry, geometry
Rule: https://community.languagetool.org/rule/show/LC_AFTER_PERIOD?lang=en-US&subId=1
Category: CASING
8b38fa2 to
b8d02f1
Compare
b8d02f1 to
be8881c
Compare
be8881c to
9823664
Compare
9823664 to
c1d56cb
Compare
c1d56cb to
4d41f59
Compare
4d41f59 to
269a76b
Compare
1 participant
Closes #497.