Skip to content

Commit 074f847

Browse files
committed
Use multi-dollar string interpolation
1 parent 6b6d5a0 commit 074f847

File tree

8 files changed

+35
-31
lines changed

8 files changed

+35
-31
lines changed

buildSrc/src/main/kotlin/base-convention.gradle.kts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@ kotlin {
5252
sourceSets.configureEach {
5353
languageSettings {
5454
optIn("kotlin.time.ExperimentalTime")
55+
enableLanguageFeature("MultiDollarInterpolation")
5556
if (!name.startsWith("common") &&
5657
!name.startsWith("jvm") &&
5758
!name.startsWith("android")

couchbase-lite-ee/src/commonTest/ee/kotbase/BaseVectorSearchTest.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -216,9 +216,9 @@ abstract class BaseVectorSearchTest : BaseDbTest() {
216216
val expr = vectorExpression ?: wordsQueryDefaultExpression()
217217

218218
if (metric != null) {
219-
append("ORDER BY APPROX_VECTOR_DISTANCE($expr, \$vector, \"$metric\") ")
219+
append($$"""ORDER BY APPROX_VECTOR_DISTANCE($$expr, $vector, "$$metric") """)
220220
} else {
221-
append("ORDER BY APPROX_VECTOR_DISTANCE($expr, \$vector) ")
221+
append($$"ORDER BY APPROX_VECTOR_DISTANCE($$expr, $vector) ")
222222
}
223223

224224
append("LIMIT $limit")

couchbase-lite-ee/src/commonTest/ee/kotbase/VectorSearchTestMain.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1078,7 +1078,7 @@ class VectorSearchTestMain : BaseVectorSearchTest() {
10781078
createWordsIndex(config)
10791079

10801080
assertThrowsCBLException(CBLError.Domain.CBLITE, CBLError.Code.INVALID_QUERY) {
1081-
executeWordsQuery(limit = 300, whereExpression = "APPROX_VECTOR_DISTANCE(vector, \$vector) < 0.5 OR catid = 'cat1'")
1081+
executeWordsQuery(limit = 300, whereExpression = $$"APPROX_VECTOR_DISTANCE(vector, $vector) < 0.5 OR catid = 'cat1'")
10821082
}
10831083
}
10841084

couchbase-lite-ktx/src/commonMain/kotlin/kotbase/ktx/QueryExt.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ public fun <T : Any> Query.asObjectsFlow(
5454

5555
@Deprecated("For binary compatibility", level = DeprecationLevel.HIDDEN)
5656
@JvmSynthetic
57-
@JvmName("asObjectsFlow\$default")
57+
@JvmName($$"asObjectsFlow$default")
5858
public fun <T : Any> Query.asObjectsFlow(
5959
coroutineContext: CoroutineContext?,
6060
factory: (String) -> T?,

couchbase-lite-ktx/src/commonMain/kotlin/kotbase/ktx/QueryExtensions.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ public fun <T : Any> Query.asObjectsFlow(
7575

7676
@Deprecated("For binary compatibility", level = DeprecationLevel.HIDDEN)
7777
@JvmSynthetic
78-
@JvmName("asObjectsFlow\$default")
78+
@JvmName($$"asObjectsFlow$default")
7979
public fun <T : Any> Query.asObjectsFlow(
8080
coroutineContext: CoroutineContext?,
8181
factory: (Map<String, Any?>) -> T?,

couchbase-lite/src/commonTest/kotlin/kotbase/LegacyLogTest.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -238,7 +238,7 @@ class LegacyLogTest : BaseDbTest(useLegacyLogging = true) {
238238
// @Test
239239
// fun testFileLoggingLogFilename() {
240240
// testWithConfiguration(LogLevel.DEBUG, LogFileConfiguration(scratchDirPath!!)) {
241-
// Log.e(LogDomain.DATABASE, "$$\$TEST MESSAGE")
241+
// Log.e(LogDomain.DATABASE, $$$$"$$$TEST MESSAGE")
242242
//
243243
// val files = logFiles
244244
// assertTrue(files.size >= 4)

couchbase-lite/src/commonTest/kotlin/kotbase/ParameterTest.kt

Lines changed: 15 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,11 @@ class ParameterTest : BaseDbTest() {
3131
val params = Parameters()
3232
params.setString("param", "value")
3333

34-
val query = testDatabase.createQuery(
35-
"SELECT meta().id"
36-
+ " FROM _default._default"
37-
+ " WHERE test = \$param"
34+
val query = testDatabase.createQuery($$"""
35+
SELECT meta().id
36+
FROM _default._default
37+
WHERE test = $param
38+
""".trimIndent()
3839
)
3940

4041
query.parameters = params
@@ -47,10 +48,11 @@ class ParameterTest : BaseDbTest() {
4748
val params = Parameters()
4849
params.setString("param", "value")
4950

50-
val query = testDatabase.createQuery(
51-
"SELECT meta().id"
52-
+ " FROM _default._default"
53-
+ " WHERE test = \$param"
51+
val query = testDatabase.createQuery($$"""
52+
SELECT meta().id
53+
FROM _default._default
54+
WHERE test = $param
55+
""".trimIndent()
5456
)
5557

5658
query.parameters = params
@@ -63,10 +65,11 @@ class ParameterTest : BaseDbTest() {
6365
fun testParamContents() {
6466
val params = makeParams()
6567

66-
val query = testDatabase.createQuery(
67-
"SELECT meta().id"
68-
+ " FROM _default._default"
69-
+ " WHERE test = \$param"
68+
val query = testDatabase.createQuery($$"""
69+
SELECT meta().id
70+
FROM _default._default
71+
WHERE test = $param
72+
""".trimIndent()
7073
)
7174

7275
query.parameters = params

couchbase-lite/src/commonTest/kotlin/kotbase/QueryTest.kt

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -3141,36 +3141,36 @@ class QueryTest : BaseQueryTest() {
31413141
@Test
31423142
fun testQueryDocumentWithDollarSign() {
31433143
saveDocInCollection(MutableDocument()
3144-
.setString("\$type", "book")
3145-
.setString("\$description", "about cats")
3146-
.setString("\$price", "$100")
3144+
.setString($$"$type", "book")
3145+
.setString($$"$description", "about cats")
3146+
.setString($$"$price", "$100")
31473147
)
31483148
saveDocInCollection(MutableDocument()
3149-
.setString("\$type", "book")
3150-
.setString("\$description", "about dogs")
3151-
.setString("\$price", "$95")
3149+
.setString($$"$type", "book")
3150+
.setString($$"$description", "about dogs")
3151+
.setString($$"$price", "$95")
31523152
)
31533153
saveDocInCollection(MutableDocument()
3154-
.setString("\$type", "animal")
3155-
.setString("\$description", "puppy")
3156-
.setString("\$price", "$195")
3154+
.setString($$"$type", "animal")
3155+
.setString($$"$description", "puppy")
3156+
.setString($$"$price", "$195")
31573157
)
31583158

31593159
var cheapBooks = 0
31603160
var books = 0
31613161

31623162
val q = QueryBuilder.select(
31633163
SelectResult.expression(Meta.id),
3164-
SelectResult.expression(Expression.property("\$type")),
3165-
SelectResult.expression(Expression.property("\$price"))
3164+
SelectResult.expression(Expression.property($$"$type")),
3165+
SelectResult.expression(Expression.property($$"$price"))
31663166
)
31673167
.from(DataSource.collection(testCollection))
3168-
.where(Expression.property("\$type").equalTo(Expression.string("book")))
3168+
.where(Expression.property($$"$type").equalTo(Expression.string("book")))
31693169

31703170
q.execute().use { res ->
31713171
for (r in res) {
31723172
books++
3173-
val p = r.getString("\$price")!!
3173+
val p = r.getString($$"$price")!!
31743174
if (p.substring(1).toInt() < 100) { cheapBooks++ }
31753175
}
31763176
assertEquals(2, books)

0 commit comments

Comments
 (0)