Migrate kotlinx-datetime to 0.7.1#48
Merged
jeffdgr8 merged 2 commits intojeffdgr8:mainfrom Oct 20, 2025
Merged
Conversation
jeffdgr8
requested changes
Aug 27, 2025
Owner
jeffdgr8
left a comment
There was a problem hiding this comment.
This looks good. It will need to be rebased and double-checked after the 3.2 changes are merged though.
f584375 to
e21caaa
Compare
Author
|
Update apis |
Owner
|
Be sure to run |
e21caaa to
3adca62
Compare
Owner
|
@namchuai please rebase on the vector-search branch and double check there aren't any additional kotlinx-datetime Instant references afterwards. I'll be able to merge soon. Thanks! |
28d6e4d to
6adfb85
Compare
Author
|
@jeffdgr8 rebased on vector-search feel free if you want to change the target branch. |
Owner
6adfb85 to
558db2f
Compare
jeffdgr8
approved these changes
Oct 20, 2025
jeffdgr8
requested changes
Oct 20, 2025
Owner
jeffdgr8
left a comment
There was a problem hiding this comment.
Looks like an import is missing in ResultTest.kt for kotlin.test.Ignore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kotlinx.datetime.Instantwithkotlin.time.Instantkotlinx.datetime.Clockwithkotlin.time.Clock