Skip to content

Migrate kotlinx-datetime to 0.7.1#48

Merged
jeffdgr8 merged 2 commits intojeffdgr8:mainfrom
namchuai:j/migrate-to-kotlinx-datetime-0.7
Oct 20, 2025
Merged

Migrate kotlinx-datetime to 0.7.1#48
jeffdgr8 merged 2 commits intojeffdgr8:mainfrom
namchuai:j/migrate-to-kotlinx-datetime-0.7

Conversation

@namchuai
Copy link
Copy Markdown

@namchuai namchuai commented Aug 21, 2025

  • Update kotlinx-datetime to 0.7.1
  • Replace kotlinx.datetime.Instant with kotlin.time.Instant
  • Replace kotlinx.datetime.Clock with kotlin.time.Clock
  • Dump new API definitions

@jeffdgr8 jeffdgr8 changed the title Migrate to kotlinx-datetime dependency to 0.7.1 Migrate kotlinx-datetime to 0.7.1 Aug 27, 2025
Copy link
Copy Markdown
Owner

@jeffdgr8 jeffdgr8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. It will need to be rebased and double-checked after the 3.2 changes are merged though.

@namchuai namchuai force-pushed the j/migrate-to-kotlinx-datetime-0.7 branch from f584375 to e21caaa Compare August 28, 2025 02:41
@namchuai
Copy link
Copy Markdown
Author

Update apis

@jeffdgr8
Copy link
Copy Markdown
Owner

Be sure to run ./gradlew apiDump to dump the new API definitions for all modules.

@namchuai namchuai force-pushed the j/migrate-to-kotlinx-datetime-0.7 branch from e21caaa to 3adca62 Compare August 30, 2025 02:44
@jeffdgr8
Copy link
Copy Markdown
Owner

@namchuai please rebase on the vector-search branch and double check there aren't any additional kotlinx-datetime Instant references afterwards. I'll be able to merge soon. Thanks!

@namchuai namchuai force-pushed the j/migrate-to-kotlinx-datetime-0.7 branch 2 times, most recently from 28d6e4d to 6adfb85 Compare October 17, 2025 02:13
@namchuai
Copy link
Copy Markdown
Author

namchuai commented Oct 17, 2025

@jeffdgr8 rebased on vector-search feel free if you want to change the target branch.

@jeffdgr8
Copy link
Copy Markdown
Owner

@namchuai can I have you rebase this one more time on main now that #57 is merged? It shouldn't require any further changes and I'll be able to merge once that's done. Thanks!

@namchuai namchuai force-pushed the j/migrate-to-kotlinx-datetime-0.7 branch from 6adfb85 to 558db2f Compare October 20, 2025 14:58
Copy link
Copy Markdown
Owner

@jeffdgr8 jeffdgr8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like an import is missing in ResultTest.kt for kotlin.test.Ignore.

@jeffdgr8 jeffdgr8 merged commit da1c078 into jeffdgr8:main Oct 20, 2025
2 of 8 checks passed
@namchuai namchuai deleted the j/migrate-to-kotlinx-datetime-0.7 branch October 21, 2025 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants