Skip to content

Conversation

@jfy133
Copy link

@jfy133 jfy133 commented Dec 2, 2025

I have run out of time, but I worked a bit on updating the Checkm2 module (my local database is a different version and ID on't have time to donwload the new one down)

But essentially I switch the database input(s) to either be a user-supplied path, and if not supplied, then let the respective module download it.

Then in the module switch the two val inputs to simply just the database files themselves and using the path variable. E.g., CHECKM2 module won't start until the GTDBTK2 database is recieved. Nextflow will (by default) just symlink the database into without needing a separate value. But as you've used path instead of val or the use of a param the used database, Nextflow will have staged correctly the input files in a way it 'likes' - even if the files are on another file system.

You should also make sure not to use outdir in the module itself, and rely on publishDir as specify in modules.config, so Nextflow itself can correctly publish these!

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@jfy133 jfy133 marked this pull request as draft December 2, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant