Update ParseCSVLine.cs to fix the behaviour in case of null or missing values #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am using this program in stock prediction and this is a common scenario in the stock prediction that value of some new ticker may be unknown. First case: first expected value is missing in CSV, In this case, the first line was having less number of columns than the current line. //Sample data //0,0, //0,1,1 //1,0,1 //1,1,0 Second case: after first-line expected value is missing in CSV, In this case, the previous line was having more columns than current line, So reset the array so that it does not carry the old values into missing column. //Sample data //0,0,0 //0,1, //1,0,1 //1,1,0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am using this program in stock prediction and this is a common scenario in the stock prediction that value of some new ticker may be unknown.
First case: first expected value is missing in CSV, In this case, the first line was having less number of columns than the current line.
//Sample data
//0,0,
//0,1,1
//1,0,1
//1,1,0
Second case: after first-line expected value is missing in CSV, In this case, the previous line was having more columns than current line, So reset the array so that it does not carry the old values into missing column.
//Sample data
//0,0,0
//0,1,
//1,0,1
//1,1,0
This fix is going to treat missing values as "?" which is a native representation of missing values in Encog Framework