Made a little optimization on the Equilateral Encoding code. #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
If this is an optimization, can you provide benchmarks? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started reading the first book and am currently in the Equilateral encoding part. I believe the scaling is only needed when the range is different from -1 and 1. I also defaulted the low and high values in the parameters so that you could only write n if you wished to use -1 and 1 range (I think that range might be used quite often, but as I'm just starting with AI I might be wrong). Please correct me if this is wrong or unnecessary as I'm not sure if I understood the algorithm or code completely.