chore(storybook): dsn-body toepassen op PreviewFrame visuele voorbeelden#119
Merged
jeffreylauwers merged 1 commit intomainfrom Mar 25, 2026
Merged
chore(storybook): dsn-body toepassen op PreviewFrame visuele voorbeelden#119jeffreylauwers merged 1 commit intomainfrom
jeffreylauwers merged 1 commit intomainfrom
Conversation
De PreviewFrame wrapper in de Docs-pagina's miste de dsn-body class, waardoor typography tokens (font-size, font-family, line-height) niet correct werden geërvd in het visuele voorbeeldblok. De redundante inline background-style is verwijderd — dsn-body zorgt daar nu voor. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
jeffreylauwers
pushed a commit
that referenced
this pull request
Mar 25, 2026
- Changelog: nieuwe entry v5.14.1 voor PR #119 (dsn-body op PreviewFrame) - docs/05-storybook-configuration.md: PreviewFrame-sectie bijgewerkt — achtergrond nu via dsn-body class, niet meer via redundante inline style Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Samenvatting
className="dsn-body"toegevoegd aan dePreviewFramewrapper in de Docs-pagina'sbackground-style verwijderd (wordt nu gedekt doordsn-body)Probleem
Op de Docs-pagina's (bijv. Card, Details) werden typography-tokens zoals
font-size,font-familyenline-heightniet correct geërvd in het visuele voorbeeldblok. Op de afzonderlijke story-pagina's werkte dit wél, omdat de decoratordsn-bodyop de<body>zet. In de Docs-view rendert de story inline in de Storybook-docs-pagina, waardoor Storybook's eigen CSS de typografie kon overschrijven.Oplossing
Door
dsn-bodyop dePreviewFramediv te zetten, hebben alle visuele voorbeeldblokken in alle Docs-pagina's nu de juiste typography-context — identiek aan de afzonderlijke story-canvassen.Testplan
🤖 Generated with Claude Code