feat(ModalDialog): voeg ModalDialog component toe (issue #114)#122
Merged
jeffreylauwers merged 3 commits intomainfrom Mar 26, 2026
Merged
feat(ModalDialog): voeg ModalDialog component toe (issue #114)#122jeffreylauwers merged 3 commits intomainfrom
jeffreylauwers merged 3 commits intomainfrom
Conversation
Compound component gebaseerd op het native <dialog> element met showModal() voor ingebakken focus-trap, aria-modal en inert-achtergrond. Sub-componenten: ModalDialog, ModalDialogHeader, ModalDialogHeading, ModalDialogBody, ModalDialogFooter. - aria-labelledby automatisch via React.useId() + context - Open/sluitanimatie via @starting-style en allow-discrete - Scroll-affordance schaduw in body (Lea Verou techniek) - 18 component-tokens, 16 React tests - Docs: changelog, 03-components.md, README bijgewerkt Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- header padding-block-start: 3xl (24px) → xl (16px) - header padding-inline: 3xl (24px) → xl (16px) - body padding-block: xl (16px) → 3xl (24px) - body padding-inline: 3xl (24px) → xl (16px) - footer padding-inline: 3xl (24px) → xl (16px) - footer padding-block-end: nieuw eigen token (xl, 16px) voorheen werd header-padding-block-start hergebruikt CSS footer gebruikt nu --dsn-modal-dialog-footer-padding-block-end. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…block-start Consistent met footer-padding-block-end — beide zijden nu expliciet benoemd. CSS gebruikt --dsn-modal-dialog-footer-padding-block-start. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<dialog>element met.showModal()voor ingebakken focus-trap,aria-modalsemantiek eninert-attribuut op de achtergrondModalDialog,ModalDialogHeader,ModalDialogHeading,ModalDialogBody,ModalDialogFooteraria-labelledbyautomatisch gekoppeld viaReact.useId()+ context — geen handmatige ID nodig@starting-styleenallow-discrete; uitschakelbaar viaprefers-reduced-motionTest plan
showModal())pnpm test— alle 1149 tests groenpnpm --filter storybook exec tsc --noEmit— 0 fouten🤖 Generated with Claude Code