feat(Navigation): MenuLink + MenuButton + gedeelde menu-item tokens (v5.18.0)#135
Merged
jeffreylauwers merged 1 commit intomainfrom Apr 4, 2026
Merged
feat(Navigation): MenuLink + MenuButton + gedeelde menu-item tokens (v5.18.0)#135jeffreylauwers merged 1 commit intomainfrom
jeffreylauwers merged 1 commit intomainfrom
Conversation
- MenuButton component: <button> visueel identiek aan MenuLink - iconStart, iconEnd, dotBadge props - dotBadge zweeft rechtsboven de tekst via position:relative op label - 13 React tests - menu-item.json: gedeelde tokens voor MenuLink én MenuButton (dsn.menu-item.*) - menu-link.json gereduceerd tot alleen current.* en level-indent tokens - menu-button.json verwijderd - Kleurverwijzingen MenuLink + MenuButton: action-1 → action-2 (consistent met Link) - Storybook: iconStart/iconEnd/dotBadge select argTypes, renderSingle helper, volledige docs - Docs: README.md, docs/README.md, docs/03-components.md, docs/changelog.md bijgewerkt Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
level-hiërarchie (1–4),current-staat (aria-current="page"), uitklapknop (aria-expanded),iconStart,iconEnd,numberBadgeiconStart,iconEnd,dotBadge(zweeft rechtsboven de tekst)menu-item.jsontokens — één token-set (--dsn-menu-item-*) gedeeld door beide componenten; MenuLink heeft alleencurrent.*enlevel-indentals eigen tokensWijzigingen
menu-item.json(shared) +menu-link.json(MenuLink-specifiek)Test plan
pnpm test— alle 1225 tests groenpnpm --filter storybook exec tsc --noEmit— 0 TypeScript-foutenpnpm lint— 0 lint-foutenaria-current="page"en bold tekstaria-expandedcorrect🤖 Generated with Claude Code