fix(tokens): gelijke hoogte voor input fields en buttons#143
Merged
jeffreylauwers merged 1 commit intomainfrom Apr 6, 2026
Merged
fix(tokens): gelijke hoogte voor input fields en buttons#143jeffreylauwers merged 1 commit intomainfrom
jeffreylauwers merged 1 commit intomainfrom
Conversation
Verlaag `--dsn-text-input-padding-block-start/end` van 12px naar 8px zodat `min-block-size` (48px) de hoogte bepaalt — net als bij de button. Cascadeert automatisch naar Select, SearchInput, DateInput en TimeInput. Verlaag `button-inset-inline-end` bij DateInput en TimeInput van 8px naar 4px voor compactere icoonpositie. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
jeffreylauwers
force-pushed
the
fix/input-button-height
branch
from
d41f7de to
d243888
Compare
jeffreylauwers
pushed a commit
that referenced
this pull request
Apr 6, 2026
- changelog: v5.19.0 Menu component (PR #136) + v5.19.1 form-control padding-block fix (PR #143) - README: Navigation Components (3 → 4), test count 1225 → 1234 / 61 suites - 03-components.md: Menu component toegevoegd (Navigation 3 → 4 total) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
jeffreylauwers
pushed a commit
that referenced
this pull request
Apr 6, 2026
- changelog: v5.19.0 Menu component (PR #136) + v5.19.1 form-control padding-block fix (PR #143) - README: Navigation Components (3 → 4), test count 1225 → 1234 / 61 suites - 03-components.md: Menu component toegevoegd (Navigation 3 → 4 total) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #141
Summary
dsn.form-control.padding-block-start/endinbase.json: van{dsn.space.block.lg}(12px) naar{dsn.space.block.md}(8px) — de juiste laag om dit te fixentext-input.jsondelegeert correct naar{dsn.form-control.padding-block-*}zoals voorheenmin-block-size: 48pxzorgt voor voldoende hoogtebutton-inset-inline-endbij DateInput en TimeInput: van 8px → 4px voor compactere icoonpositieDe tijdelijke workaround in
page-header.css(token-overrides voor padding-block) wordt verwijderd in defeature/page-headerPR zodra deze fix gemerged is.Test plan
pnpm test— 1234 tests groenpnpm --filter storybook exec tsc --noEmit— 0 foutenform-control→text-input/text-areavia de juiste lagen🤖 Generated with Claude Code