feat(TimeInput): rebuild with interactive clock button and Storybook docs#4
Merged
jeffreylauwers merged 4 commits intomainfrom Feb 18, 2026
Merged
feat(TimeInput): rebuild with interactive clock button and Storybook docs#4jeffreylauwers merged 4 commits intomainfrom
jeffreylauwers merged 4 commits intomainfrom
Conversation
…docs - CSS herschreven: wrapper + absolute clock button aan inline-end - Component: clock icon wordt interactieve <button> die showPicker() aanroept - Button is tabIndex=-1 en aria-hidden (toetsenbord gebruikt input direct) - Button verborgen in disabled/readOnly staat - Visueel verborgen label "Tijdkiezer openen" op de button - Action-2 kleurtokens voor icoon (default + hover) - padding-inline-end-with-icon token voor ruimte rechts - Width variants via wrapper (niet op input) - TextInput.css import toegevoegd (dsn-text-input base stijlen) - Tests volledig herschreven: 34 tests (clock button, widths, states) - Storybook: TimeInput.stories.tsx + docs.mdx + docs.md Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…con-only - Gebruikt Button component (variant='subtle', size='small', iconOnly) in plaats van een custom <button> met handmatige stijlen - CSS vereenvoudigd: hover/focus/color stijlen komen nu van Button zelf - dsn-time-input-icon-color/hover tokens niet meer nodig in CSS - Padding-inline-end token blijft (ruimte voor de button in de input) - Tests uitgebreid: controleert nu dsn-button, subtle, small, icon-only klassen - showPicker test opgeschoond en correct gemaakt Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ponent usage - dsn-time-input-icon-color en icon-hover-color tokens verwijderd uit docs (worden niet gebruikt — Button subtle regelt die kleuren zelf) - Alleen dsn-time-input-padding-inline-end-with-icon blijft staan - Anatomy sectie bijgewerkt: klokknop omschreven als Button component Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…width prop - dsn-visually-hidden bestond niet — vervangen door eigen .dsn-time-input__button-label (correct visually-hidden patroon in CSS) - ::-webkit-calendar-picker-indicator en inner-spin-button verborgen zodat het native browserklokje niet doorheen het eigen icoon schijnt - width prop verwijderd — vaste sm-breedte (16ch) in wrapper - Storybook: Widths story verwijderd, width argType verwijderd - Docs bijgewerkt: vaste sm-breedte uitgelegd Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
inline-end<button type="button">dieshowPicker()aanroepttabIndex=-1enaria-hidden="true"— toetsenbordgebruikers bedienen de input directdisabledenreadOnlystaat--dsn-time-input-icon-coloren hover variant)padding-inline-end-with-icontoken zorgt dat tekst nooit achter de knop looptTextInput.cssimport toegevoegd voor dedsn-text-inputbase stijlenTimeInput.stories.tsx+TimeInput.docs.mdx+TimeInput.docs.mdaangemaaktTest plan
pnpm run build)🤖 Generated with Claude Code