fix: force https for connection to cdn #131
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: remove not required charset at script tag
casperdcl
approved these changes
Feb 5, 2024
jeffreytse
reviewed
Feb 5, 2024
Contributor
|
yes but |
Contributor
|
actually nvm, just checked and it seems you can force |
Contributor
Author
I know and what is the intention of the comment? |
jeffreytse
reviewed
Feb 7, 2024
Owner
jeffreytse
left a comment
jeffreytse
left a comment
There was a problem hiding this comment.
@Rotzbua Have you considered the compatability of browsers?
Contributor
Author
For what case or browser? Netscape? |
jeffreytse
force-pushed
the
master
branch
3 times, most recently
from
bd29ba6 to
df61d0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: remove not required charset at script tag
fixes #144