Marked Feature added: Pause per monitor when maximized/fullscreen#250
Open
JannickRichter wants to merge 1 commit intojeffshee:masterfrom
Open
Marked Feature added: Pause per monitor when maximized/fullscreen#250JannickRichter wants to merge 1 commit intojeffshee:masterfrom
JannickRichter wants to merge 1 commit intojeffshee:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements per-monitor detection for maximized and fullscreen windows. Instead of pausing all video wallpapers globally when any window is maximized, it now only pauses the video on the specific monitor where the maximized/fullscreen window is located.
Changes
[src/utils.py] (WindowHandler class)
monitor_statesdictionaryis_any_maximizedandis_any_fullscreenflags[src/player/video_player.py] (VideoPlayer class)
monitor_statesinstance variablemonitor_nameparameterBehavior
Testing
Tested on X11 with dual-monitor setup (HDMI-0 + DP-0). Verified that:
Notes
Gdk.Displayfor monitor geometry andWnckfor window positionsHoping for a updated flatpak soon :)