Skip to content

feat: Give the user the option to specify an image proxy for Discord RPC#2152

Open
Quinnca77 wants to merge 7 commits into
jeffvli:developmentfrom
Quinnca77:image-proxy
Open

feat: Give the user the option to specify an image proxy for Discord RPC#2152
Quinnca77 wants to merge 7 commits into
jeffvli:developmentfrom
Quinnca77:image-proxy

Conversation

@Quinnca77

Copy link
Copy Markdown

What does this fix?

I personally use Navidrome, and embed my cover arts directly into the files. I then instruct Navidrome to use these embeds as the first priority for viewing the cover art, rather than the associated album image. This does not interface well with Feishin Discord RPC, as Feishin asks for the album image directly on the album id. Rather than doing this, we can do the following:

  1. Use getCoverArt endpoint on music server
  2. Get image and send it to an image proxy
  3. Image proxy sends back a link pointing to the image resource, which is accessible from the internet
  4. Send link to Discord RPC

This feature works out of the box if Image proxy is selected for the server type, and the link https://uguu.se/upload is given.

Verification steps

  • I have ran linting.
  • Checked for myself with a song on Navidrome of which the embedded cover art is different from the album cover art that this works. Tested with uguu.se.

Things I'm not too sure about

  • How the image proxy returns the image link can differ per service, and this is not configurable at the moment.
  • The way the configuration is changed for Serve discord images from server and its text.

Additional notes

I would like to say that I have been enjoying Feishin a lot and do not plan to return to any other platform after experiencing this one. Thank you all for making such a great app!
Second, this is my first open-source contribution. I do not have much experience working in big codebases like these. Feel free to let me know what I could've done better :)

@vercel

vercel Bot commented Jun 13, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
feishin Ready Ready Preview, Comment Jun 13, 2026 9:28am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant