feat: implemented new fullscreen player design - #2227
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@jagrit2u good idea! I take it that its just a mockup again right? |
|
I wanted to share one concern about removing the song information from the fullscreen player. The larger title, artist, and album text under the cover art makes it much easier to identify the currently playing song at a glance. The customizable track metadata is also useful for users who want to see details such as the release year, format, or something else they’ve chosen to display. With both sections removed, the only remaining song information is in the small control bar at the bottom, which is much less visible in fullscreen mode. Could this be made optional instead? A toggle to show or hide the title/artist/album and track metadata would allow users to choose between a cleaner layout and a more informative one. |
|
@Keviddle Yep, just another mockup. @york9675 I agree, this could be optional. Track title, artist, album, etc. could be added to the Player Items configuration in Settings (where codec, year, etc. are already configurable, but title, artist, and album aren't since they've always been visible). If no metadata items are selected, the artwork could use full available space. As metadata items are enabled, the artwork could scale down accordingly to make room for them. |
|
Also agree with adding back configurable metadata items. also misclicked the close pull request button instead of the comment button, oops |
|
Next round of updates
|
|
Gave it another shot at allowing max customization to accomodate to all feature requests.
|
|
Next small update
I decided to not remove the tooltip for the fullscreen player and instead just increase the show delay slightly because all in all I think the tooltip serves a valid purpose. There may be people who do not know that the cover art has a function/serves as a button. Therefore only increasing the image is not a sufficient hint in my opinion. Especially while keeping in mind that even buttons with rather obvious or globally accepted icons, like the play button, have a tooltip. But I did increase the tooltip show delay to the default amount for other tooltips as well. The show delay now is in line with other buttons used throughout the fullscreen player For the second point, I agree that the default should try to get as close as possible to be a default that suffices for most people. But I would argue to still include the setting to choose between small, medium and large for the cover art. We are already looking at an application that offers a maximum number of customization options. If we compare the number of options we have to customize how the lyrics looks like or how the play next table is structured, then we still have a lot of leeway on the number of settings that we could provide for the metadata :D And including for example #2286 in this change, then it seems like there is a need for some for an even bigger album art. But of course there are just my two cents towards that topic :) I am open to other arguments or discussions |
output.mp4Only album art view is good to have. Designed this where clicking active tab icon brings album art front and center, with or without metadata as configured. |
















I would like to propose this solution for the request #2224
I like the mockup/concept @jagrit2u proposed, and took the liberty to give it a shot at implementing this design
closes #2224, closes #2260, closes #2285, likely closes #2286