feat(player): add autoplay on open - #2246
Open
Pegoku wants to merge 2 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Pegoku
marked this pull request as ready for review
July 16, 2026 20:48
jeffvli
reviewed
Jul 31, 2026
Comment on lines
+2625
to
+2632
| if (version < 32) { | ||
| state.general.autoPlayOnOpen = false; | ||
| } | ||
|
|
||
| return persistedState; | ||
| }, | ||
| name: 'store_settings', | ||
| version: 31, | ||
| version: 32, |
Owner
There was a problem hiding this comment.
You can remove the migration here. Not needed as the persist middleware already handles merging new keys.
Owner
|
Unfortunately it doesn't seem to work for mpv, only the web player. Mpv may require an additional listener to trigger playback start instead of just the player state. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2241