feat: implemented random button in the playlist view - #2273
Open
Keviddle wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
thanks @Keviddle :) |
kgarner7
requested changes
Jul 25, 2026
| return sortSongList(filtered, sortBy, sortOrder); | ||
| }, [data?.items, query, searchTerm]); | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps -- refreshRevision intentionally triggers a new random order | ||
| }, [data?.items, query, searchTerm, refreshRevision]); |
Collaborator
There was a problem hiding this comment.
You should only refresh the filter if the sort by is random and the sortBy is random.
| } | ||
|
|
||
| return sortSongList(searched, sortBy, sortOrder); | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps -- refreshRevision intentionally triggers a new random order |
Collaborator
There was a problem hiding this comment.
Likewise here, this only needs to be refreshed when refresh version changes and the sort order is random.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an implementation that fixes #2270.
Having a random function in many places in the app already, only lead me to the conclusion that it makes sense to implement it in the playlist view as well.
Therefore my changes include
Closes #2270