feat: adds option to view top rated songs in the Favorite Songs section - #2289
Open
dsimonds wants to merge 3 commits into
Open
feat: adds option to view top rated songs in the Favorite Songs section#2289dsimonds wants to merge 3 commits into
dsimonds wants to merge 3 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
dsimonds
force-pushed
the
DS/AddsTopRatedSongs
branch
from
July 26, 2026 22:56
c3b37b0 to
b5a3648
Compare
dsimonds
force-pushed
the
DS/AddsTopRatedSongs
branch
from
July 26, 2026 23:05
b5a3648 to
d7660ca
Compare
dsimonds
marked this pull request as draft
July 27, 2026 19:34
dsimonds
force-pushed
the
DS/AddsTopRatedSongs
branch
from
July 27, 2026 19:34
d7660ca to
41eb401
Compare
dsimonds
marked this pull request as ready for review
July 27, 2026 20:07
jeffvli
reviewed
Jul 31, 2026
| getFavoriteSongs: async (args) => { | ||
| const { apiClientProps, query } = args; | ||
|
|
||
| const type = query.type === 'favorite' ? 'favorite' : 'rating'; |
Owner
There was a problem hiding this comment.
Small nitpick, but the type const is redundant as you can just perform the comparison with query.type.
Author
There was a problem hiding this comment.
Thanks! Updated to just use query.type here, and in the same spot in subsonic-controller.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an option to view a user's Top Rated songs on the Artist's Detail page
This partially satisfies the spirit #2205 (allowing ratings to be utilized more) by providing the option to view the user's top rated songs of the artist in the "Favorite songs" section, since some users rely mainly on star ratings instead of favorites. Now the user can select the new "Favorite | Ratings" segmented control option to switch between songs that are favorited, or songs that have a rating of 3 or more stars.
Favorite:
ordered by: userFavorite > userRating > playCount > albumId > trackNumber
Rating:
ordered by: userRating > userFavorite > playCount > albumId > trackNumber
Notes: