Render comments via platform-agnostic inclusion #886
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_includes/comments.html
. Rather than renaming the include_file, the following changes have also been made:JEKYLL_ENV=production
andcomments: false
front matter checks up intopost
layout.site.disqus.shortname
into_includes/comments.html
.this.page.identifier
javascript variable is set to{{ page.id }}
.Comments have been disabled for this post.
message in posts withcomments: false
in front matter.Rationale
A generic inclusion / include_file name would mean a user could opt to another comments-provider-platform by editing the generic include_file rather than editing the
post
layout as well as introducing a new include_file at user's source-dir.