Skip to content

Render comments via platform-agnostic inclusion #886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2025

Conversation

ashmaroli
Copy link
Member

  • Move markup to render disqus comments into _includes/comments.html. Rather than renaming the include_file, the following changes have also been made:
    • move JEKYLL_ENV=production and comments: false front matter checks up into post layout.
    • move check for site.disqus.shortname into _includes/comments.html.
    • this.page.identifier javascript variable is set to {{ page.id }}.
  • Render a Comments have been disabled for this post. message in posts with comments: false in front matter.

Rationale

A generic inclusion / include_file name would mean a user could opt to another comments-provider-platform by editing the generic include_file rather than editing the post layout as well as introducing a new include_file at user's source-dir.

@ashmaroli
Copy link
Member Author

@jekyllbot: merge +major

@jekyllbot jekyllbot merged commit 17714d1 into jekyll:master Apr 7, 2025
3 checks passed
jekyllbot added a commit that referenced this pull request Apr 7, 2025
@ashmaroli ashmaroli deleted the comments-inclusion branch April 7, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants