-
-
Notifications
You must be signed in to change notification settings - Fork 0
chore(deps): update dependency @trivago/prettier-plugin-sort-imports to v6 #285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed everything up to ff0cb78 in 1 minute and 14 seconds. Click for details.
- Reviewed
13lines of code in1files - Skipped
2files when reviewing. - Skipped posting
1draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. package.json:34
- Draft comment:
Upgrading @trivago/prettier-plugin-sort-imports to v6.0.0 introduces breaking changes (ESM support, Node ≥20 requirement). Consider updating the Node engine in package.json (currently '>=18') to avoid compatibility issues. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% This comment is about a dependency change. The rules explicitly state "Do NOT comment on dependency changes, library versions that you don't recognize, or anything else related to dependencies." This is a clear dependency version upgrade, and the comment is asking the author to consider updating the Node engine requirement. Even though the comment might be technically correct about breaking changes, it falls under the category of dependency changes which should be ignored according to the rules. The comment does provide specific, actionable information about a potential compatibility issue. It's not just commenting on the dependency change itself, but pointing out a concrete incompatibility between the new dependency version and the existing Node engine specification. This could be seen as a legitimate code quality or compatibility concern rather than just a dependency comment. While the comment does identify a potential compatibility issue, the rules are explicit: "Do NOT comment on dependency changes, library versions that you don't recognize, or anything else related to dependencies." The comment is fundamentally about a dependency upgrade and its implications. If the dependency truly requires Node 20+, this would likely be caught during installation or runtime, not requiring a PR comment. This comment should be deleted because it violates the rule against commenting on dependency changes. The comment is about the implications of upgrading a dependency version, which falls squarely under "anything else related to dependencies."
Workflow ID: wflow_SMBt4taUfvnGrlC5
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
This PR contains the following updates:
4.3.0->6.0.0Release Notes
trivago/prettier-plugin-sort-imports (@trivago/prettier-plugin-sort-imports)
v6.0.0Compare Source
Breaking Changes
New features
<BUILTIN_MODULES>placeholder #381 by @sdotson - Add support for sorting Node.js builtin modules to a specific position using<BUILTIN_MODULES>placeholder inimportOrder<SEPARATOR>placeholder #339 - Add<SEPARATOR>keyword for fine-grained control over import group separation whenimportOrderSeparationis enabledimportOrderExcludeoption #384 by @RyderKishan - Add support for excluding specific files from import sorting using glob patternssort-imports-ignoredetection #358 by @ckwalsh - Improved detection ofsort-imports-ignorecomments throughout the file, not just at line 1Performance improvements
removeNodesFromOriginalCode()performance #356 by @ckwalsh - Replace RegExp logic with string slices for better performanceRefactoring
Chores
v5.2.2Compare Source
v5.2.1Compare Source
v5.2.0Compare Source
v5.1.0Compare Source
v5.0.1Compare Source
v5.0.0Compare Source
New features
importOrderImportAttributesKeyword#273 by chentsulinConfiguration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.