v2.0.0 update #74

Lindsay-Needs-Sleep · 2020-11-02T05:50:21Z

Sorry, both version updates are in one PR because I have moved on in master.

I still suggest creating a release at the last commit of 1.1.0 because it includes some fixes and updates for those who don't want to drop iOS 9 yet.

v2.0.0

Platforms affected

android and ios

Description

(ios) BREAKING - Update Google Cast SDK (iOS Sender -> 4.5.2)
- Google Cast SDK - iOS sender 4.5.0+ has minimum iOS 10
  - But, all tests on the plugin work fine for iOS 9.3.5, so it appears to work on iOS 9 anyways. :/
  - But, since [email protected] no longer supports iOS 9+10 we will only be testing on iOS 11+.
- With the update, additional entries are required in config.xml for cast to work on iOs 14 (if built with Xcode 12+) (see README.md)

v1.1.0

Platforms affected

android and ios

Description

Update Google Cast SDKs (iOS -> 4.4.8, android -> 19.0.0)
(android) simulate mediaSessionId
Add Audiobook chapter metadata
(android) Fix queue bug: media returned with no items (if you load media right after a page reload)
(android) [Issue Listen for the X icon action from the cast notification #73] Fix Push Notification stop casting button
Live stream issue Fix for live stream media, incorporated this pr's fix as well.
Add to documentation #72 Added to documentation

Testing

Included tests for new bug fixes.
refactored tests: make them a bit more straightforward to run (only have auto, manual, and interaction [primary and seconrdary] tests now instead of auto, manual, primary1, primary2, and secondary).
refactored tests: extract common parts for building media requests (mediaInfo and metadata)
refactored tests: extract common parts for testing that correct mediainfo is returned

Checklist

I've updated the documentation as necessary
If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
I've run npm test and no errors were found (run npm style to auto-fix errors it can)
I've run the tests (See Readme)
I added automated test coverage as appropriate for this change (See Readme Contributing section)

- add an iOS troubleshooting tip - remove documentation for unimplemented `setCustomReceivers` - reformat supported API section - Add link to tests for example usage

- Apparently `receiverListener` is required for ApiConfig now (tests_auto.js) - receiverListener also doesn't always give unavailable status before available anymore (tests_manual_primary_2.js) - Apparently it takes sometime for session.leave to take complete effect and cause the session to be removed from the browser's memory (tests_auto.js) - Add slightly more detailed instructions for desktop (tests_manual_primary_2.js)

- unify html test files between desktop chrome and mobile via test_starter.js - prep for merging primary part 1 + 2 - prep for pulling out the manual solo tests

…ts_interaction_primary.js

…/failure detection

…t is determined later in runtime now

It is available on iOS and desktop chrome, but not Android for some reason. Google... >.>

…o have not metadata

…hat that is what it is for?) (chrome desktop does not appear to send the originalAirDate to the cast device because it doesn't appear to make it to android)

…tion.

If you have a session and media loaded, then reload the page and load a queue (from main device, or from an external) the first returned media did not have any items.

…ing button: Add tests for stop casting and pause from push notification

[Issue #11] [PR #12]

Lindsay-Needs-Sleep · 2020-11-07T08:09:47Z

Well I guess this is the 2.0.0 PR now.

I still suggest creating a release at the last commit of 1.1.0 because it includes some fixes and updates for those who don't want to drop iOS 9 yet.

…that developers can easily remember what these entries in their config.xml are for

…i-info" setting

ghenry22 · 2021-05-25T05:52:06Z

https://cordova.apache.org/docs/en/10.x/guide/platforms/ios/index.html
As you mentioned and as mentioned here iOS 11 is the minimum version supported since cordova-ios platform v6.0 so I think it's valid to set that as the minimum requirement for the plugin at this time.

I have forked the repo and merged this PR and been testing with it for a few weeks now. So far everything works as expected and has been very smooth.

@Lindsay-Needs-Sleep I'd suggest merging this PR to master and releasing an updated version to NPM so people start using it more widely. It's been in review for going on 6 months.

dkanada · 2021-05-25T06:08:47Z

Since we no longer use this project within Jellyfin it has been archived in our organization. Although I believe @Lindsay-Needs-Sleep does have merge rights here, I'd suggest moving to their fork seeing as we no longer plan on supporting it on our side.

Fixed issue when using the sendMessage method on iOS implementation

Lindsay-Needs-Sleep · 2021-05-29T02:14:06Z

I can't approve my own PR's, so I wasn't able to merge this one.

I have updated the readme on this fork with a notice to point to the miloproductionsinc fork.
I'm not working there anymore, so I can't say how active it will be there.

But thanks again for the support and work you guys at Jellyfin did for this plugin! :)

Lindsay-Needs-Sleep and others added 23 commits October 22, 2020 22:25

[v1.1.0-dev] styling fixes

e823585

[issue jellyfin-archive#72] Documentation changes:

1e86759

- add an iOS troubleshooting tip - remove documentation for unimplemented `setCustomReceivers` - reformat supported API section - Add link to tests for example usage

Fix mocha obscuring errors if they occur in a promise in a before/after

4e29fd2

(test) WIP re-org test files:

46d9bc0

- unify html test files between desktop chrome and mobile via test_starter.js - prep for merging primary part 1 + 2 - prep for pulling out the manual solo tests

(test) WIP Move promary interaction tests from tests_manual.js to tes…

581ddbb

…ts_interaction_primary.js

(test) WIP - Fix custom_mocha_html_reporter.js test suite end success…

8468f6e

…/failure detection

(test) WIP - Fix isDesktop, needs to be dynamically retrieved since i…

28d8c50

…t is determined later in runtime now

(test) Finish making the re-organized Interaction Tests work together

659ea43

(android) Work-around to simulate mediaSessionId

028adbc

It is available on iOS and desktop chrome, but not Android for some reason. Google... >.>

[no change] Update readme and fix text in interaction test

40ae8a6

Add Audiobook chapter metadata

6e8d8db

If no metadata supplied the returned MediaInfo from native should als…

df267c7

…o have not metadata

Make originalAirDate use the broadcastDate key (it is my best guess t…

374ca1a

…hat that is what it is for?) (chrome desktop does not appear to send the originalAirDate to the cast device because it doesn't appear to make it to android)

(test) Extract file: mediaGenerateAndAssert.js to reduce code duplica…

a1f1e3c

…tion.

(android) Fix queue-related bug:

e39a848

If you have a session and media loaded, then reload the page and load a queue (from main device, or from an external) the first returned media did not have any items.

(android) [Issue jellyfin-archive#73] Fix Push Notification stop cast…

508ce1a

…ing button: Add tests for stop casting and pause from push notification

(test) WIP Create test for audio live stream

07e9c89

[Issue #11] [PR #12]

(android) WIP support live streams

e1eb920

[Issue #11] [PR #12]

(ios) Fixed JSON serialization for streams with infinite stream duration

ed7d9be

[Issue #11] [PR #12]

Change cocoapods URL

d3995be

Update Google Cast SDKs

281733e

[v1.1.0]

34949c5

Lindsay-Needs-Sleep force-pushed the master branch from 2d8b23c to 34949c5 Compare November 4, 2020 07:42

Lindsay-Needs-Sleep mentioned this pull request Nov 4, 2020

media not playing when casting + casting youtube videos #75

Closed

Lindsay-Needs-Sleep changed the title ~~v1.1.0 update~~ v2.0.0 update Nov 7, 2020

Lindsay-Needs-Sleep added 3 commits November 7, 2020 01:19

[v1.1.0-dev]

5cef017

(doc) Add a default comment to the required config.xml attributes so …

7aac33d

…that developers can easily remember what these entries in their config.xml are for

(ios) Update iOS Google Cast SDK - minimum supported iOS is now 10.0

b198e5c

Lindsay-Needs-Sleep added 2 commits November 7, 2020 01:22

(ios) remove unused (now useless) "com.apple.developer.networking.wif…

b655e46

…i-info" setting

[v2.0.0]

4dbb43b

Lindsay-Needs-Sleep force-pushed the master branch from 206b8d1 to 4dbb43b Compare November 7, 2020 08:23

Lindsay-Needs-Sleep added 5 commits November 28, 2020 13:28

Update README.md with correct url for running browser tests

0250501

(ios) fix crash when media is loaded without metadata

94aa4a6

[v2.0.1]

6bee8d6

README.md - Add links to test videos

785c41e

Add link to chromecast icon assets

1b94f78

Lindsay-Needs-Sleep force-pushed the master branch from be4a74f to 1b94f78 Compare November 30, 2020 02:48

Fixed issue when using the sendMessage method on iOS implementation

1feef15

Lindsay-Needs-Sleep added 2 commits May 28, 2021 19:54

Merge pull request #15 from enricodente/sendmessage-fix

578d020

Fixed issue when using the sendMessage method on iOS implementation

README - Add notice asking for new person to maintain

d82f07e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

v2.0.0 update #74

v2.0.0 update #74

Uh oh!

Lindsay-Needs-Sleep commented Nov 2, 2020 •

edited

Loading

Uh oh!

Lindsay-Needs-Sleep commented Nov 7, 2020

Uh oh!

ghenry22 commented May 25, 2021

Uh oh!

dkanada commented May 25, 2021

Uh oh!

Lindsay-Needs-Sleep commented May 29, 2021

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

6 participants

v2.0.0 update #74

Are you sure you want to change the base?

v2.0.0 update #74

Uh oh!

Conversation

Lindsay-Needs-Sleep commented Nov 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

v2.0.0

Platforms affected

Description

v1.1.0

Platforms affected

Description

Testing

Checklist

Uh oh!

Lindsay-Needs-Sleep commented Nov 7, 2020

Uh oh!

ghenry22 commented May 25, 2021

Uh oh!

dkanada commented May 25, 2021

Uh oh!

Lindsay-Needs-Sleep commented May 29, 2021

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

6 participants

Lindsay-Needs-Sleep commented Nov 2, 2020 •

edited

Loading