This repository was archived by the owner on Jun 23, 2022. It is now read-only.
Replace old references with current ones; remove dead code #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ri; Remove more dead code; this commit is still broken
dkanada
reviewed
Dec 14, 2019
Bond-009
suggested changes
Dec 16, 2019
Bond-009
suggested changes
Dec 20, 2019
| { | ||
| /// <summary> | ||
| /// Provides api methods centered around an HttpClient | ||
| /// </summary> | ||
| public partial class ApiClient : BaseApiClient, IApiClient | ||
| { | ||
| public event EventHandler<GenericEventArgs<RemoteLogoutReason>> RemoteLoggedOut; | ||
| public event EventHandler<GenericEventArgs<AuthenticationResult>> Authenticated; | ||
| public event EventHandler<GenericEventArgs<AuthenticationResult>> OnAuthenticated; |
| } | ||
|
|
||
| var dict = new QueryStringDictionary { }; | ||
| var dict = new NameValueCollection { }; |
There was a problem hiding this comment.
Suggested change
| var dict = new NameValueCollection { }; | |
| var dict = new NameValueCollection(); |
| { | ||
| if (query == null) | ||
| { | ||
| throw new ArgumentNullException("query"); | ||
| } | ||
|
|
||
| var dict = new QueryStringDictionary { }; | ||
| var dict = new NameValueCollection{ }; |
There was a problem hiding this comment.
Suggested change
| var dict = new NameValueCollection{ }; | |
| var dict = new NameValueCollection(); |
| { | ||
| if (query == null) | ||
| { | ||
| throw new ArgumentNullException("query"); | ||
| } | ||
|
|
||
| var dict = new QueryStringDictionary { }; | ||
| var dict = new NameValueCollection { }; |
There was a problem hiding this comment.
Suggested change
| var dict = new NameValueCollection { }; | |
| var dict = new NameValueCollection(); |
| @@ -1173,7 +1109,7 @@ public Task SendMessageCommandAsync(string sessionId, MessageCommand command) | |||
|
|
|||
| if (command.TimeoutMs.HasValue) | |||
| { | |||
| cmd.Arguments["Timeout"] = command.TimeoutMs.Value.ToString(CultureInfo.InvariantCulture); | |||
| cmd.Arguments["Timeout"] = command.TimeoutMs?.ToString(CultureInfo.InvariantCulture); | |||
| catch (Exception ex) | ||
| { | ||
| _logger.ErrorException("Error receiving web socket message", ex); | ||
| _logger.LogError("Error receiving web socket message", ex); |
There was a problem hiding this comment.
Suggested change
| _logger.LogError("Error receiving web socket message", ex); | |
| _logger.LogError(ex, "Error receiving web socket message"); |
| if (!Enum.TryParse(type.ToString(), true, out System.Net.WebSockets.WebSocketMessageType nativeType)) | ||
| { | ||
| _logger.Warn("Unrecognized WebSocketMessageType: {0}", type.ToString()); | ||
| _logger.LogWarning("Unrecognized WebSocketMessageType: {0}", type.ToString()); |
There was a problem hiding this comment.
Suggested change
| _logger.LogWarning("Unrecognized WebSocketMessageType: {0}", type.ToString()); | |
| _logger.LogWarning("Unrecognized WebSocketMessageType: {0}", type); |
| if (!Enum.TryParse(_client.State.ToString(), true, out WebSocketState commonState)) | ||
| { | ||
| _logger.Warn("Unrecognized WebSocketState: {0}", _client.State.ToString()); | ||
| _logger.LogWarning("Unrecognized WebSocketState: {0}", _client.State.ToString()); |
There was a problem hiding this comment.
Suggested change
| _logger.LogWarning("Unrecognized WebSocketState: {0}", _client.State.ToString()); | |
| _logger.LogWarning("Unrecognized WebSocketState: {0}", _client.State); |
|
|
||
| _socket.Opened += (sender, args) => taskCompletionSource.TrySetResult(true); | ||
| _socket.Closed += _socket_Closed; | ||
| _socket.Closed += Socket_Closed; |
There was a problem hiding this comment.
Suggested change
| _socket.Closed += Socket_Closed; | |
| _socket.Closed += OnSocketClosed; |
| _socket = new WebSocket4Net.WebSocket(url.ToString()); | ||
|
|
||
| _socket.MessageReceived += websocket_MessageReceived; | ||
| _socket.MessageReceived += Websocket_MessageReceived; |
There was a problem hiding this comment.
Suggested change
| _socket.MessageReceived += Websocket_MessageReceived; | |
| _socket.MessageReceived += OnWebsocketMessageReceived; |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not 100% sure if this has exact parity with the server's API, but it builds and works.