This repository was archived by the owner on Mar 28, 2026. It is now read-only.
DO NOT MERGE - Add HDR playback on Wayland (vulkan, gpu-next)#1068
Closed
andrewrabert wants to merge 6 commits intomasterfrom
Closed
DO NOT MERGE - Add HDR playback on Wayland (vulkan, gpu-next)#1068andrewrabert wants to merge 6 commits intomasterfrom
andrewrabert wants to merge 6 commits intomasterfrom
Conversation
c49fd79 to
bfabe82
Compare
19f3979 to
892d17d
Compare
892d17d to
4b47cf3
Compare
mpv outputs PQ/BT.2020 regardless of source content when HDR swapchain is active. Signal this output colorspace to Wayland instead of the source colorspace.
Pass pause=no option to loadfile command. Without this, mpv keeps the previous pause state which causes subsequent files to stay paused.
Fixes WebEngine overlay alpha blending (OSD fade) over mpv video. Qt Vulkan caused crashes on Radeon GPUs and broke transparency. - Remove QVulkanInstance and setGraphicsApi(Vulkan) for Qt - Add alpha buffer to surface format for subsurface blending - mpv subsurface retains its own Vulkan instance for HDR
When the window resizes, immediately render a frame with the new swapchain dimensions instead of waiting for mpv's update signal. Fixes subsurface not resizing when video is paused.
1e544a1 to
cdecfba
Compare
Member
Author
|
Continuing work on this at https://github.com/jellyfin-labs/jellyfin-desktop-cef |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hacked-together, but provides functioning HDR playback on Plasma Wayland (Arch Linux). This likely will not be merged for quite a while. It relies upon non-upstream changes to mpv [1] [2].
Compile with:
Partially resolves (Wayland only) https://github.com/jellyfin/jellyfin-desktop/issues/362, https://github.com/jellyfin/jellyfin-desktop/issues/523
Tested on:
Appears visually identical to standalone mpv running with this config: