Use External Player Popup #4487
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Surajkaran04
added a commit
to Surajkaran04/jellyfin-androidtv
that referenced
this pull request
Feb 27, 2025
This comment has been minimized.
This comment has been minimized.
nielsvanvelzen
requested changes
Mar 31, 2025
There was a problem hiding this comment.
The getPlaybackDestination function in PlaybackLauncher is supposed to choose the destination. Adding a new getExternalPlayer function is against that concept.
I'm also not convinced we need this feature. If you want to use an external player you can configure that in the app settings.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds a long-click popup to the play button with the option to use an external player.
Issues
Fixes #4465
Fixes #4261