Skip to content

Comments

Use External Player Popup#4487

Closed
haydenkz wants to merge 9 commits intojellyfin:masterfrom
haydenkz:issue-4465
Closed

Use External Player Popup#4487
haydenkz wants to merge 9 commits intojellyfin:masterfrom
haydenkz:issue-4465

Conversation

@haydenkz
Copy link

@haydenkz haydenkz commented Feb 26, 2025

Changes

Adds a long-click popup to the play button with the option to use an external player.

Issues

Fixes #4465
Fixes #4261

Surajkaran04 added a commit to Surajkaran04/jellyfin-androidtv that referenced this pull request Feb 27, 2025
@marinierb

This comment has been minimized.

Copy link
Member

@nielsvanvelzen nielsvanvelzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The getPlaybackDestination function in PlaybackLauncher is supposed to choose the destination. Adding a new getExternalPlayer function is against that concept.

I'm also not convinced we need this feature. If you want to use an external player you can configure that in the app settings.

@SerhiyRomanov

This comment has been minimized.

@kingp0dd

This comment has been minimized.

@jellyfin-bot jellyfin-bot added the merge conflict Conflicts prevent merging label Apr 14, 2025
@nielsvanvelzen
Copy link
Member

Closing as stale (author did not address review feedback or comment)

@cch85
Copy link

cch85 commented May 14, 2025

Definitively something I would like to see again (pretty sure it did exist in the past), few another request are based on this one.
IMHO this has few use cases, i,e playing video not well supported by the default player, and external player would definitively help especially if Jellyfin does not have transcoding enabled.

@cch85
Copy link

cch85 commented May 14, 2025

PlaybackLauncher

Just curious what do you have in mind as alternative if adding a new getExternalPlayer function is against the concept of getPlaybackDestination function in PlaybackLauncher supposed to choose the destination?
Would you mind clarifying?

@pavichokche
Copy link

This would be a super nice feature, because sometimes random outlier movies/episodes might not function with the built-in player and it can save SO MUCH time of going in/out of the advanced video player settings to toggle external player on and then off later. PLEASE consider it

@IlIlIIlIlIlIIllIIlIlI

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge conflict Conflicts prevent merging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add option to play via external player directly from movie/episode screen Bring back per item External Player

9 participants