Use External Player Popup#4487
Use External Player Popup#4487haydenkz wants to merge 9 commits intojellyfin:masterfrom haydenkz:issue-4465
Conversation
This comment has been minimized.
This comment has been minimized.
nielsvanvelzen
left a comment
There was a problem hiding this comment.
The getPlaybackDestination function in PlaybackLauncher is supposed to choose the destination. Adding a new getExternalPlayer function is against that concept.
I'm also not convinced we need this feature. If you want to use an external player you can configure that in the app settings.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Closing as stale (author did not address review feedback or comment) |
|
Definitively something I would like to see again (pretty sure it did exist in the past), few another request are based on this one. |
Just curious what do you have in mind as alternative if adding a new getExternalPlayer function is against the concept of getPlaybackDestination function in PlaybackLauncher supposed to choose the destination? |
|
This would be a super nice feature, because sometimes random outlier movies/episodes might not function with the built-in player and it can save SO MUCH time of going in/out of the advanced video player settings to toggle external player on and then off later. PLEASE consider it |
Changes
Adds a long-click popup to the play button with the option to use an external player.
Issues
Fixes #4465
Fixes #4261