Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable configuration of Ask To Skip duration for intro skipper #4519

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

johnpc
Copy link

@johnpc johnpc commented Mar 13, 2025

Changes:

  • Added a new setting in the Playback Preferences screen that allows users to customize how long the Skip Intro/Outro button stays on screen.
  • The setting provides a slider to adjust the duration from 3 to 20 seconds, with a default of 8 seconds. This gives users more control over their viewing experience based on their reaction speed and preferences.

Issues:

Screenshot 2025-03-13 at 12 07 07 AM

NOTE: This is my first contribution to jellyfin-androidtv. Please let me know if you have any feedback I am happy to make whatever updates are desired by the maintainers.

Copy link
Member

@nielsvanvelzen nielsvanvelzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in #4187 there is no interest in adding this right now. The new player UI will always show a "skip" button (when available) in its control overlay so if you miss the "popup" you can still skip if you missed the timer.

@johnpc
Copy link
Author

johnpc commented Mar 31, 2025

Understood.

Out of curiosity what is the perceived harm of offering this preference? It seems to align well with the existing preferences like "Next Up Timer Duration"

Also, I'm not sure what you mean by "The new player UI will always show a "skip" button (when available) in its control overlay". Are you describing an upcoming feature that will mitigate this problem? The control overlay that I see does not currently include a skip button during intros. When I miss the 8 second window, the opportunity is gone.

Maybe this would be valuable as a stop-gap if the upcoming feature you're referencing is far off? I see that the proposal to add it to the control overlay (#4177) was from 6 months ago, so I am concerned it will be a while before the demand for configurable skip duration is met. When the feature you're talking about is released, perhaps then we could consider removing this setting if we determine it's just clutter at that point?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants