Respect server-side user preference for live TV default view #4537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsvanvelzen
requested changes
Mar 31, 2025
Comment on lines
+136
to
+137
| // Add coroutine scope for async operations | ||
| single { kotlinx.coroutines.MainScope() } |
There was a problem hiding this comment.
Coroutine scopes should never be added to dependency injection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR respects the server-side user preference for the "Default view" for the Live TV category.
This is configurable on the web client in your
User Preferences -> Home -> Live TV -> Default Screen. SeeFor example, my preference is the TV Guide, so it skips directly to the TV Guide view:
Screen.Recording.2025-03-22.at.4.09.07.PM.mov
Worth noting not every view has an equivalent on android tv, so if it's an unsupported selection, it will show the same default screen that appears today.
If we like this idea of having the client respect the server preferences, I can do the same for other categories as well (like movies / shows / music / etc) but it's much cleaner to do one thing at a time.
Let me know what else you'd like me to include to get this over the finish line! Tbh for Live TV, none of the views other than Guide are useful for me at all, so this would save a lot of clicks!
Issues