Fix recording from playback overlay, passing programId to default gettimer#5396
Merged
nielsvanvelzen merged 1 commit intojellyfin:masterfrom Feb 12, 2026
Conversation
WizardOfYendor1
force-pushed
the
fix/pass-programid-to-timer-defaults
branch
from
0227dc6 to
e9e0cff
Compare
nielsvanvelzen
approved these changes
Feb 12, 2026
Member
nielsvanvelzen
left a comment
nielsvanvelzen
left a comment
There was a problem hiding this comment.
I'm unable to test this change but it makes sense
nielsvanvelzen
added
bug
Member
|
As a sidenote: the server should NEVER send a min/max value for dates and must always return |
Contributor
Author
@nielsvanvelzen I agree :-). In fact read this PR comment I have on the server side. There may also need to be a fix put into the SDK.... jellyfin/jellyfin#16191 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The playback overlay's recordProgram() calls getDefaultTimer() without passing the programId, causing the server to return DateTime.MinValue for StartDate/EndDate. The Kotlin SDK then mangled these into year-0000 dates that the server rejected with HTTP 400 (separate issue).
Pass program.id to getDefaultTimer() so the server returns real dates from the EPG program data. This matches how LiveProgramDetailPopupHelper already does it correctly https://github.com/jellyfin/jellyfin-androidtv/blob/master/app/src/main/java/org/jellyfin/androidtv/ui/LiveProgramDetailPopupHelper.kt#L95-L100
Changes
Added the programid to the getDefaultTImer call. Remove the unnecessary copy in the subsequent isSeries block.
Code assistance
Opus 4.6 was used to aide in researching/debugging and making some of these changes. Extra scrutiny suggested.
Issues
jellyfin/jellyfin#16190
#4371