Playback: fall back to transcoding on player errors#5399
Open
nalet wants to merge 1 commit intojellyfin:masterfrom
Open
Playback: fall back to transcoding on player errors#5399nalet wants to merge 1 commit intojellyfin:masterfrom
nalet wants to merge 1 commit intojellyfin:masterfrom
Conversation
Some devices fail direct play at runtime due to decoder/init issues even when the server playback plan marks the stream compatible. Add allowAudioStreamCopy/allowVideoStreamCopy options and a conservative retry ladder: - retry 1: force audio transcode (disallow audio stream copy) - retry 2: force video transcode (disallow video stream copy) + request stereo downmix Also improve error logging and suppress the first retry toast when we expect an immediate auto-recovery.
Member
|
Please fill in the pull request template as requested |
Author
|
Filled out the PR template sections (Changes, Code assistance, Issues) at the top of the description. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
allowAudioStreamCopy/allowVideoStreamCopyto playback options (and pass them into the playback info request; previously hard-coded totrue).Code assistance
Issues
Fixes #5398