Fix left D-Pad focus "escape" on channel and chapter display overlay#5413
Open
WizardOfYendor1 wants to merge 2 commits intojellyfin:masterfrom
Open
Fix left D-Pad focus "escape" on channel and chapter display overlay#5413WizardOfYendor1 wants to merge 2 commits intojellyfin:masterfrom
WizardOfYendor1 wants to merge 2 commits intojellyfin:masterfrom
Conversation
WizardOfYendor1
force-pushed
the
fix/channeloverlayleftboundarystop
branch
from
c358ae1 to
ed9557d
Compare
WizardOfYendor1
force-pushed
the
fix/channeloverlayleftboundarystop
branch
from
ba2099a to
e57498e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a user presses down on the D Pad, a channel (or chapter) overlay display is loaded. If you scroll all the way to the right, you stop. You can either select that channel/chapter or not - as you would expect.
When you do the same scrolling all the way to the left boundary, a strange thing happens. The "up" overlay displays in the background and the user is left in a strange state. Only "fix" is to go back and press down again.
Changes
An effective focus trap was implemented/refactored to make the left boundary the same at the right boundary... and to remove showing the "other" overlay in the background which was a mess.
Branch built and tested on a real firetv device.
Code assistance
After several false starts by myself, Opus 4.6 was used to help to trace down the correct method to make this work and identify other areas that may be affected. Assisted with creation of a basic test and regression test plan.
Testing Steps
Validated this functionality on firetv device:
Live TV — Channel Changer
Movie/Episode — Chapter Selector
7. While watching content with chapters, open the chapter selector
8. Scroll LEFT to the first chapter — should stop at the boundary
9. Keep pressing LEFT — nothing should happen
10. Press RIGHT — should scroll right through chapters normally
11. Press DPAD_CENTER/ENTER — should jump to the selected chapter
12. Press BACK — should dismiss the popup
Misc regression checks ("just because" sanity checks, should be unaffected. May not be complete):
Playback Transport Controls
13. While watching any content (not live TV), press a key to show transport overlay — should still appear normally
14. While live TV channel changer is open, transport controls should NOT appear behind it
Home Screen
15. Navigate a content row and scroll LEFT to the first item. Keep pressing LEFT — behavior identical to master version
16. Check settings, login page scrolling behavior.
Browse/Folder Screens
17. Browse a library (movies, shows, etc.) — full LEFT at position 0 should be the same — behavior identical to master version